Task #12318 (closed)
Map annotations: indexing? event logs?
Reported by: | mtbcarroll | Owned by: | jamoore |
---|---|---|---|
Priority: | critical | Milestone: | 5.1.0-m4 |
Component: | ORM | Version: | n.a. |
Keywords: | n.a. | Cc: | omero-team@… |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | 0.0d |
Sprint: | n.a. |
Description
Determine follow-up work on map annotations, to include: changes to map annotation properties being logged against the parent object, and proper indexing of their values. Then adjust this ticket description accordingly. (-:
Change History (7)
comment:1 Changed 10 years ago by jamoore
- Milestone changed from 5.1.0-m1 to 5.1.0-m2
- Priority changed from major to critical
comment:2 Changed 10 years ago by mtbcarroll
Perhaps we could add @Index to the key column of MapFields in object.vm, if one can use it on collection properties.
Indeed, once https://github.com/openmicroscopy/openmicroscopy/pull/3000 is in we may even be able to use the JPA 2.1 @Index annotation.
comment:3 Changed 10 years ago by jamoore
Adding @Index (or similar) to MapAnnotation would certainly add the values to the Annotation entry (e.g. searchPrx.byType("Annotation") but not to, say, the Image. For that we will need to adjust https://github.com/openmicroscopy/openmicroscopy/blob/v.5.0.5/components/server/src/ome/services/fulltext/FullTextBridge.java#L176
comment:4 Changed 10 years ago by jamoore
- Milestone changed from 5.1.0-m2 to 5.1.0-m3
Since this won't require a DB/schema change, pushing to m3. Note that the addition of some Hibernate Search annotation on the map fields (in addition to the map annotations) will need to be investigated.
comment:5 Changed 10 years ago by jamoore
- Resolution set to fixed
- Status changed from new to closed
- https://github.com/openmicroscopy/openmicroscopy/pull/3334 enables update events for changes to map items
- https://github.com/openmicroscopy/openmicroscopy/pull/3383 enables indexing of the map annotation values themselves.
comment:6 Changed 10 years ago by jmoore <josh@…>
- Remaining Time set to 0
(In [09fda64418514fcb49207635e011208f5f5b3d7f/ome.git] on branch develop) Index map annotations (Fix #12318)
In order for the name-value pairs attach to objects
to be searchable by Lucene, a handler for the map
annotations needed to be added.
comment:7 Changed 10 years ago by Sébastien Besson <seb.besson@…>
(In [e501d4ecccd802c3d8d914c76780f541c98ef537/ome.git] on branch develop) Merge pull request #3383 from joshmoore/map-indexing
Index map annotations (Fix #12318)
Pushing for being done with the schema work. (Some initial effort is minimally needed).