Bug: Windows bin\omero shell: TypeError: _isdir() takes exactly 1 argument (0 given)

[spli]

Windows 7, 64 bit, Ice 3.5, Python 2.7.6, Java 1.7.55, OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309

C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309>bin\omero shell

...

Original exception was:
Traceback (most recent call last):
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\bin\\omero", line 125, in <module>
    rv = omero.cli.argv()
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\cli.py", line 1242, in argv
    cli.invoke(args[1:])
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\cli.py", line 791, in invoke
    stop = self.onecmd(line, previous_args)
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\cli.py", line 860, in onecmd
    self.execute(line, previous_args)
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\cli.py", line 940, in execute
    args.func(args)
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\python\omero\plugins\basics.py", line 89, in __call__
    ipshell = IPShellEmbed(args.arg)
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\fallback\IPython\Shell.py", line 169, in __init__
    user_ns=user_ns)
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\fallback\IPython\ipmaker.py", line 521, in make_IPython
    IP.pre_config_initialization()
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\fallback\IPython\iplib.py", line 835, in pre_config_initialization
    self.db = pickleshare.PickleShareDB(rc.ipythondir + "/db")
  File "C:\OMERO.server-5.0.2-rc1-73-71bbbc7-ice35-b309\lib\fallback\IPython\Extensions\pickleshare.py", line 53, in __init__
    if not self.root.isdir():
TypeError: _isdir() takes exactly 1 argument (0 given)

Full error output attached.

[spli]

Windows 7 bin\omero shell

[rleigh]

This looks like exactly the problem we fixed in the initial set of path.py fixes or py27 on Windows. Does this code need fixing to use either our path.py or the workaround that our path.py is using internally?

[spli]

Perhaps update ipython? lib/repository/ipython-0.10.1.tar.gz in omero, latest appears to be
`
$ ipython --version
2.1.0
`

[rleigh]

Could we fix this by dropping the outdated embedded ipython and updating the docs to add ipython to the existing list of python prerequisites?

[jamoore]

I'm for updating the embedded, but I'd really prefer to not drop it.

[spli]

​https://github.com/openmicroscopy/openmicroscopy/pull/3435