Task #12406 (closed)
Opened 10 years ago
Closed 8 years ago
Bug: divide by zero in SlidebookReader
| Reported by: | omero-qa | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | Unscheduled |
| Component: | Bio-Formats | Version: | 5.0.2 |
| Keywords: | SlidebookReader, our-fault | Cc: | RGrattan@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
https://www.openmicroscopy.org/qa2/qa2/qa/feedback/9371/
java.lang.ArithmeticException: / by zero at loci.formats.in.SlidebookReader.initFile(SlidebookReader.java:943) at loci.formats.FormatReader.setId(FormatReader.java:1244) at loci.formats.ImageReader.setId(ImageReader.java:727) at loci.formats.ReaderWrapper.setId(ReaderWrapper.java:529) at loci.formats.ChannelFiller.setId(ChannelFiller.java:263) at loci.formats.ReaderWrapper.setId(ReaderWrapper.java:529) at loci.formats.ChannelSeparator.setId(ChannelSeparator.java:274) at loci.formats.ReaderWrapper.setId(ReaderWrapper.java:529) at ome.formats.importer.ImportLibrary.open(ImportLibrary.java:323) at ome.formats.importer.ImportLibrary.importImage(ImportLibrary.java:499) at org.openmicroscopy.shoola.env.data.OMEROGateway.importImage(OMEROGateway.java:6369) at org.openmicroscopy.shoola.env.data.OmeroImageServiceImpl.importFile(OmeroImageServiceImpl.java:1347) at org.openmicroscopy.shoola.env.data.views.calls.ImagesImporter.importFile(ImagesImporter.java:77) at org.openmicroscopy.shoola.env.data.views.calls.ImagesImporter.access$000(ImagesImporter.java:53) at org.openmicroscopy.shoola.env.data.views.calls.ImagesImporter$1.doCall(ImagesImporter.java:102) at org.openmicroscopy.shoola.env.data.views.BatchCall.doStep(BatchCall.java:144) at org.openmicroscopy.shoola.util.concur.tasks.CompositeTask.doStep(CompositeTask.java:226) at org.openmicroscopy.shoola.env.data.views.CompositeBatchCall.doStep(CompositeBatchCall.java:126) at org.openmicroscopy.shoola.util.concur.tasks.ExecCommand.exec(ExecCommand.java:165) at org.openmicroscopy.shoola.util.concur.tasks.ExecCommand.run(ExecCommand.java:276) at org.openmicroscopy.shoola.util.concur.tasks.AsyncProcessor$Runner.run(AsyncProcessor.java:91) at java.lang.Thread.run(Unknown Source)
Change History (9)
comment:1 Changed 10 years ago by rleigh
- Component changed from from QA to Bio-Formats
comment:2 Changed 10 years ago by rleigh
comment:3 Changed 10 years ago by jburel
- Keywords SlidebookReader our-fault added
comment:4 Changed 9 years ago by mlinkert
- Milestone changed from Unscheduled to 5.1.1
Moving to 5.1.1 for triage.
comment:5 Changed 9 years ago by mlinkert
- Milestone changed from 5.1.1 to 5.2.0-m1
comment:6 Changed 9 years ago by jamoore
- Milestone changed from 5.2.0 to B-F-5.2.0
Splitting due to milestone decoupling.
comment:7 Changed 8 years ago by mlinkert
- Owner mlinkert deleted
Expect this to take substantial time given the state of Slidebook support. Closing as wontfix or needsfunding would be OK with me.
comment:8 Changed 8 years ago by sbesson
- Milestone changed from B-F-5.2.0 to Unscheduled
comment:9 Changed 8 years ago by sbesson
- Resolution set to wontfix
- Status changed from new to closed
As of Bio-Formats 5.2.0, recent Slidebook files can be opened on all platforms using the 3i Slidebook reader. As this reader is completely externalized from Bio-Formats and fully maintained by 3i (see https://www.intelligent-imaging.com/techanswers.php#SLDinFiji), closing all these tickets with wontfix.
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
Also affects develop:
% BF_MAX_MEM=10g BF_DEVEL=1 LOCI_DEVEL=1 SCIFIO_DEVEL=1 CLASSPATH=./artifacts/loci_tools.jar ./tools/showinf 9371/Lyn\ siRNA\ maskedlowergain.sld Checking file format [Olympus Slidebook] Initializing reader SlidebookReader initializing 9371/Lyn siRNA maskedlowergain.sld Finding offsets to pixel data Determining dimensions Exception in thread "main" java.lang.ArithmeticException: / by zero at loci.formats.in.SlidebookReader.initFile(SlidebookReader.java:944) at loci.formats.FormatReader.setId(FormatReader.java:1315) at loci.formats.ImageReader.setId(ImageReader.java:753) at loci.formats.ReaderWrapper.setId(ReaderWrapper.java:569) at loci.formats.tools.ImageInfo.testRead(ImageInfo.java:992) at loci.formats.tools.ImageInfo.main(ImageInfo.java:1074)This looks like either getSizeX or getSizeY is returning zero. The logic immediately above special cases this situation, but the division isn't handled by it.