Task #12420 (closed)
Bug: MIPAV importer plugin broken due to model changes
Reported by: | rleigh | Owned by: | mlinkert |
---|---|---|---|
Priority: | minor | Milestone: | 5.1.0-m4 |
Component: | Bio-Formats | Version: | 5.0.2 |
Keywords: | n.a. | Cc: | pdetampe@… |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description
PlugInBioFormatsImporter?.java will not compile:
labtop:plugins pascal$ javac -cp /Applications/mipav:/Applications/mipav/bioformats_package.jar PlugInBioFormatsImporter.java PlugInBioFormatsImporter.java:201: cannot find symbol symbol : method getDimensionsPhysicalSizeX(int,int) location: interface loci.formats.meta.IMetadata Float dimPhysSizeX = store.getDimensionsPhysicalSizeX(0, 0); PlugInBioFormatsImporter.java:202: cannot find symbol symbol : method getDimensionsPhysicalSizeY(int,int) location: interface loci.formats.meta.IMetadata Float dimPhysSizeY = store.getDimensionsPhysicalSizeY(0, 0); PlugInBioFormatsImporter.java:203: cannot find symbol symbol : method getDimensionsPhysicalSizeZ(int,int) location: interface loci.formats.meta.IMetadata Float dimPhysSizeZ = store.getDimensionsPhysicalSizeZ(0, 0); PlugInBioFormatsImporter.java:204: cannot find symbol symbol : method getDimensionsTimeIncrement(int,int) location: interface loci.formats.meta.IMetadata Float dimTimeInc = store.getDimensionsTimeIncrement(0, 0); 4 errors
The method calls in question were removed from the OME data model in 2010, and so it has been non-functional for some time.
Fixing the above error is simple (change getDimensions to getPixels and drop the pixel index). However, there may be additional problems with the code.
Ideally, there should be a maven pom to allow this to be added to our regular CI infrastructure to pick up any future breakage.
Change History (3)
comment:1 Changed 10 years ago by mlinkert
- Milestone changed from Unscheduled to 5.0.4
comment:2 Changed 9 years ago by mlinkert
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed 9 years ago by Melissa Linkert <melissa@…>
(In [580655fa8c2a43edcfd1692a32ffca084cbe101d/bioformats.git] on branch develop) Add MIPAV stub component
See #12420. The licensing and download terms for MIPAV are such that
deploying it to Artifactory is at best questionable. To facilitate
compile testing, this instead adds stubs of the classes needed by the MIPAV
plugin.
PR opened to resolve compile errors and add the plugin to the build: https://github.com/openmicroscopy/bioformats/pull/1532