Task #12421 (closed)
Opened 10 years ago
Closed 10 years ago
Review `%eventId%` in `omero.fs.repo.path`
Reported by: | mtbcarroll | Owned by: | mtbcarroll |
---|---|---|---|
Priority: | minor | Milestone: | 5.0.3 |
Component: | Import | Version: | 5.0.2 |
Keywords: | FS | Cc: | fs@… |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description
When I use %eventId% in omero.fs.repo.path it always seems to expand to 1. I have not tested extensively, nor investigated the value's provenance, but the issue seems worth reviewing someday. There is no urgency as I do not believe that we have ever actually documented this expansion term.
Change History (5)
comment:1 Changed 10 years ago by jamoore
- Milestone changed from Unscheduled to 5.0.3
- Owner changed from jamoore to mtbcarroll
comment:2 Changed 10 years ago by mtbcarroll
My PR doesn't change this; I think it was probably always broken. (In 5.0 it always expands to -1.) Is the action item probably then simply to remove it as one of the available expansion terms?
comment:3 Changed 10 years ago by jamoore
If it's broken and you don't see an immediate fix, then go ahead and remove it.
comment:5 Changed 10 years ago by mtbcarroll
- Resolution set to fixed
- Status changed from accepted to closed
I don't know if this is worth an "unscheduled" ticket. Either let's figure out what's wrong with your implementation, or not worry about it. My guess is that the transaction that the load is doing is read-only in which case we don't create a new event. You'll need to find a location that has a read-write transaction and store the eventId ahead of time. (Or something else is wrong entirely)