BUG: Search for AND and OR

[pwalczysko]

A query like

nd2 weird AND attachment

will be interpreted atm by our clients as

weird AND attachment

This is because Lucene is interpreting the query as such

(nd2 SHOULD, weird MUST, attachment MUST)

which marginalises the SHOULD term. The expected result with

nd2 SHOULD, (weird MUST attachment MUST) SHOULD

interpretation is passed to Lucene using syntax

nd2 OR (weird AND attachment)

This is not possible now in the clients, because the clients strip the brackets away (probably).
dlindner suggests the solution:

for a query like
nd2 weird AND attachment
the clients will add the brackets for Lucence and pass
nd2 (weird AND attachment)

which would result in the expected result for the user.

[jamoore]

Dominik, once you're existing search PRs are through, would you like to give this a try? It will mean Java & Python will diverge briefly, but we can update the tests to either have someone else modify web/python, or to have an explanation ready for Will on his return.

[dlindner]

Done in Insight ( AND terms now are encapsulated within brackets).
Insight and Web are already diverge at the moment (wrt AND across multiple fields). Will said he'll take my Java LuceneQueryBuilder? class and Testcase and convert it to Python once he's back, so Insight and Web will construct the same query.

[jamoore]

NB: if we decide we have time and would rather solve this with your Java code for both clients, then we could try detecting a prefix to byFullText:

   >>LuceneQueryBuilder<<: *.svs