build target fails after touching file

[mtbcarroll]

After checking out develop I do a ./build.py build-dev then run,

$ ./build.py -f components/blitz/build.xml test
...
===============================================
blitz.unit
Total tests run: 409, Failures: 38, Skips: 112
Configuration Failures: 19, Skips: 72
===============================================
[TestNG] Time taken by org.uncommons.reportng.JUnitXMLReporter@51a5aa86: 250 ms
[TestNG] Time taken by org.uncommons.reportng.HTMLReporter@801b120: 232 ms
The tests failed.

BUILD SUCCESSFUL
Total time: 20 seconds
$ touch components/blitz/test/ome/formats/utests/AnnotationTest.java
$ ./build.py -f components/blitz/build.xml test 
Buildfile: /home/mtbc/src/openmicroscopy/components/blitz/build.xml
Entering /home/mtbc/src/openmicroscopy/components/blitz...

testng-init:
:: Apache Ivy 2.3.0 - 20130110142753 :: http://ant.apache.org/ivy/ ::
:: loading settings :: file = /home/mtbc/src/openmicroscopy/etc/ivysettings.xml
	conflict on /home/mtbc/src/openmicroscopy/components/blitz/target/libs/test/perf4j.jar in [test]: 0.9.16 won
	conflict on /home/mtbc/src/openmicroscopy/components/blitz/target/libs/test/ice.jar in [test]: 3.4.2 won

lifecycle.test-compile:
Compiling 1 source file to /home/mtbc/src/openmicroscopy/components/blitz/target/test-classes
/home/mtbc/src/openmicroscopy/components/blitz/test/ome/formats/utests/AnnotationTest.java:27: cannot find symbol
symbol  : class TestServiceFactory
location: class ome.formats.utests.AnnotationTest
		ServiceFactoryPrx sf = new TestServiceFactory().proxy();
		                           ^
/home/mtbc/src/openmicroscopy/components/blitz/test/ome/formats/utests/AnnotationTest.java:31: cannot find symbol
symbol  : class TestEnumerationProvider
location: class ome.formats.utests.AnnotationTest
        store.setEnumerationProvider(new TestEnumerationProvider());
                                         ^
2 errors

BUILD FAILED
/home/mtbc/src/openmicroscopy/components/antlib/resources/lifecycle.xml:260: The following error occurred while executing this line:
/home/mtbc/src/openmicroscopy/components/antlib/resources/lifecycle.xml:153: Compile failed; see the compiler error output for details.

Total time: 5 seconds

Why does touching a source file break the build?

[ajpatterson]

Running a default build does not seem to be able to correct the issue. I need to do a clean each time.

./build.py clean build-dev test-compile
./build.py -f components/blitz/build.xml test

This takes about 25 mins to check each code change.

[bpindelski]

Andrew: build-dev already does clean and test-compile. You don't have to specify it twice. The dependencies of the build-dev target are <target name="build-dev" depends="clean,init,build-default,test-compile,build-eclipse"/>

[ajpatterson]

There is the same issue with files in: components/tools/OmeroJava/test/

This makes writing any new tests a tortuous process.

[ajpatterson]

Same problem is apparent on dev_5_0 branch.

[ajpatterson]

Reverting the changes suggested by Jean-Marie (​https://github.com/bpindelski/openmicroscopy/commit/0da325c099d042be3a0c75280817aca6f86b72c8#diff-d41d8cd98f00b204e9800998ecf8427e) does not fix the problem so is not connected.

[bpindelski]

I managed to hunt it down to a wrong classpath provided for javac in the test-compile target, which test depends on. We should add the blitz-test.jar to the classpath (in the case of blitz; for other components the name will be different). I'll look into how I can append to the classpath.

[bpindelski]

PR now open ​https://github.com/openmicroscopy/openmicroscopy/pull/2995.

[Sébastien Besson <seb.besson@…>]

(In [3cc6d5af5f880395ca56e316b3a9f2bf00d52571/ome.git] on branch develop) Merge pull request #2995 from bpindelski/12537_test-compile

Fix #12537: Add target/test-classes to test classpath.