Bug: Inter-group links may be created

[mtbcarroll]

1. start with a fresh database
2. run create_users script from omero-setup
3. start up Insight
4. log in as root
5. create read-annotate group read-annotate with owner read-annotate-owner
6. create private group private with owner private-owner
7. create new user 'image-owner' who is a member of both read-annotate and private
8. create new user 'tag-owner' who is a member of both read-annotate and private
9. switch user to image-owner
10. import two images into read-annotate
11. switch user to tag-owner
12. tag both image-owner's images with the same new tag
13. switch user to image-owner
14. (shell) as root run bin/omero hql --all 'select parent.details.group.id, child.details.group.id from ImageAnnotationLink' and observe that for each row the group ID in Col1 matches that in Col2
15. right-click one of the images and move it to private
16. (shell) as root run bin/omero hql --all 'select parent.details.group.id, child.details.group.id from ImageAnnotationLink' and recoil in horror

Note that our usual test user setup does not include a regular user who is in both a read-annotate and a private group.

​https://github.com/openmicroscopy/openmicroscopy/pull/2401 has SQL for deleting existing inter-group annotations, though note that the set of annotatable classes has since changed.

#11779 should fix this bug, but it definitely seemed worth documenting.

[jamoore]

Makes sense. Perhaps the most critical thing to come from this will be a test then?

[jamoore]

Passing to mark along with 11752

[jburel]

Keeping it m3 since the work is on-going and will probably be completed during that milestone.

[bpindelski]

Test implemented in ​https://github.com/openmicroscopy/openmicroscopy/pull/3163.

[mtbcarroll]

Now fixed by ​​https://github.com/openmicroscopy/openmicroscopy/pull/3228.