MetamorphReader: Metadata incorrectly parsed

[sbesson]

While reading Metamorph files, the Metadata comment is sanitized before being parsed into the handler (see ​https://github.com/openmicroscopy/bioformats/blob/v5.0.6/components/formats-gpl/src/loci/formats/in/MetamorphReader.java#L714). Since XMLTools.sanitizeXML converts all ampersands into spaces, the delimiter is no longer valid (​https://github.com/openmicroscopy/bioformats/blob/v5.0.6/components/formats-gpl/src/loci/formats/in/MetamorphHandler.java#L125) and the description fails to be correctly parsed.

See /ome/team/sbesson/A._WTChlor.2.nd_[Stage1Position52_] for an example of such incorrect parsing

sbesson@necromancer /ome/team/sbesson/A._WTChlor.2.nd_[Stage1__Position52_] $ bash ~/bftools/showinf -nopix A.\ WTChlor.2.nd
Checking file format [Metamorph STK]
Initializing reader
MetamorphReader initializing A. WTChlor.2.nd
Initializing A. WTChlor.2.nd
Looking for STK file in /ome/team/sbesson/A._WTChlor.2.nd_[Stage1__Position52_]
...
Reading series #0 metadata
#10;Binning: 1 x 1 #13;
#10;Digitizer: 16-bit (17 MHz) #13; #10;Multiplication Gain
#10;Illumination: 5 mCherry #13; #10;HaloChlor #13; #10;
#10;Region: 512 x 512, offset at (0, 0) #13;
#10;Shading: Off #13;
#10;Subtract: Off #13;
#10;Temperature: -80 #13;
ASI LED Intensity: 99
ASI LED Shutter: Closed
ApplicationName: MetaMorph
ApplicationVersion: 7.8.4.0
Average: 1 #13; #10;Trigger
Camera Bit Depth: 16
Enabled: Yes #13; #10;Cooler
Exposure: 1 sec #13;
Gain: Gain 1 #13; #10;Camera
...

[mlinkert]

PR opened: ​https://github.com/openmicroscopy/bioformats/pull/1432

[Melissa Linkert <melissa@…>]

(In [c62aca39b30cb917cb80fe73f9e784c7b9911262/bioformats.git] on branch develop) Metamorph: fix description delimiter to account for XML sanitization

Fixes #12633.