Task #12665 (closed)
Opened 9 years ago
Closed 9 years ago
BUG: Tagging dialog flaw when multitag
| Reported by: | pwalczysko | Owned by: | wmoore |
|---|---|---|---|
| Priority: | critical | Milestone: | 5.1.0 |
| Component: | Web | Version: | 5.1.0-m1 |
| Keywords: | n.a. | Cc: | ux@… |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | n.a. |
| Sprint: | n.a. |
Description
All works here fine.
The only remark (but this happens on latest as well, so not a regression or fault of this PR):
- multiselect P/D/I/S/P and add some tags
- click Save in tagging dialog
- click + to bring up tagging dialog again
- the tags are all loaded only on the left-hand side, even in cases when all the selected entities are tagged already, and no tags are loaded on the right-hand side (already tagged, not available for tagging field is empty)
- this is specific for multiselection, single selections work as expected
- this behaviour is okay in Insight
I would suggest to correct the remark above only in case it is not too painful, as it was there before (in the released version) and is not a crucial workflow-breaker.
Change History (6)
comment:1 Changed 9 years ago by pwalczysko
comment:2 Changed 9 years ago by jamoore
I would think so. Anyone else? If so, want to change the milestone?
comment:3 Changed 9 years ago by wmoore
I don't know how much work this would be, since I am not yet familiar with Andreas' Tagging dialog. Presumably tags should be shown in the left column unless they are on ALL of the selected images? E.g this can't be used to remove a tag that is only on some of the images.
comment:4 Changed 9 years ago by pwalczysko
@wmoore : Correct, this is exactly how the dialog works in Insight. The taggging dialog is showing a tag which has been added only to some of the images on the left-hand side (= suggesting to add it to the images which do not have it yet).
After you added the tag to all selected images, next time you bring the tagging dialog up with the same image selection, it should display the tag on the right-hand side (ready to be removed. Which is exactly what Web is failing to do.
The Tagging section of https://www.openmicroscopy.org/private/ome-internal/testing_scenarios/Annotate.html might be of help
comment:5 Changed 9 years ago by wmoore
webclient views.annotate_tags needs to populate selected_tags when "batch" multiple objects are selected.
This will add tags to the right column in the tagging dialog, but then also need to know when they've been de-selected and then un-link these tags from everything.
Will be a day's work probably.
comment:6 Changed 9 years ago by wmoore
- Resolution set to fixed
- Status changed from new to closed
Note that the problem is present also in 5.0 series. Candidate to include for 5.0.7 ?