BUG: Crash with moving focus from plate during "Save All"process.

[rkferguson]

Was testing ​https://github.com/openmicroscopy/openmicroscopy/pull/3475 using OMERO.insight-5.1.0-m3-1131-2b7bc2c-ice35-b409-mac_Java7+ trout user-3 read-annotate-1

Behaved as expected for a couple of tries.

Then clicked "Imported" and "Save to All" and while it was busy selected another plate, selected a cell and clicked Preview. Got a crash with error message below. When I went back I was able to select the first plate and the "Save All" progress bar was at 55% - Insight then crashed out.

java.lang.Exception: Abnormal termination due to an uncaught exception.
java.lang.IllegalArgumentException: No image.
	at org.openmicroscopy.shoola.env.data.views.calls.ThumbnailLoader.<init>(ThumbnailLoader.java:440)
	at org.openmicroscopy.shoola.env.data.views.MetadataHandlerViewImpl.loadThumbnails(MetadataHandlerViewImpl.java:100)
	at org.openmicroscopy.shoola.agents.metadata.ThumbnailLoader.load(ThumbnailLoader.java:101)
	at org.openmicroscopy.shoola.agents.metadata.view.MetadataViewerModel.fireThumbnailsLoading(MetadataViewerModel.java:1012)
	at org.openmicroscopy.shoola.agents.metadata.view.MetadataViewerComponent.setViewedBy(MetadataViewerComponent.java:1153)
	at org.openmicroscopy.shoola.agents.metadata.RenderingSettingsLoader.handleResult(RenderingSettingsLoader.java:132)
	at org.openmicroscopy.shoola.env.data.events.DSCallAdapter.eventFired(DSCallAdapter.java:90)
	at org.openmicroscopy.shoola.env.data.views.BatchCallMonitor$1.run(BatchCallMonitor.java:124)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:312)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:733)
	at java.awt.EventQueue.access$200(EventQueue.java:103)
	at java.awt.EventQueue$3.run(EventQueue.java:694)
	at java.awt.EventQueue$3.run(EventQueue.java:692)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:703)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)
Abnormal termination due to an uncaught exception.
java.lang.IllegalArgumentException: No image.
	at org.openmicroscopy.shoola.env.data.views.calls.ThumbnailLoader.<init>(ThumbnailLoader.java:440)
	at org.openmicroscopy.shoola.env.data.views.MetadataHandlerViewImpl.loadThumbnails(MetadataHandlerViewImpl.java:100)
	at org.openmicroscopy.shoola.agents.metadata.ThumbnailLoader.load(ThumbnailLoader.java:101)
	at org.openmicroscopy.shoola.agents.metadata.view.MetadataViewerModel.fireThumbnailsLoading(MetadataViewerModel.java:1012)
	at org.openmicroscopy.shoola.agents.metadata.view.MetadataViewerComponent.setViewedBy(MetadataViewerComponent.java:1153)
	at org.openmicroscopy.shoola.agents.metadata.RenderingSettingsLoader.handleResult(RenderingSettingsLoader.java:132)
	at org.openmicroscopy.shoola.env.data.events.DSCallAdapter.eventFired(DSCallAdapter.java:90)
	at org.openmicroscopy.shoola.env.data.views.BatchCallMonitor$1.run(BatchCallMonitor.java:124)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:312)
	at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:733)
	at java.awt.EventQueue.access$200(EventQueue.java:103)
	at java.awt.EventQueue$3.run(EventQueue.java:694)
	at java.awt.EventQueue$3.run(EventQueue.java:692)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:703)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:242)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)
Exception in thread "AWT-EventQueue-0"

	at org.openmicroscopy.shoola.env.ui.UserNotifierImpl.showErrorDialog(UserNotifierImpl.java:191)
	at org.openmicroscopy.shoola.env.ui.UserNotifierImpl.notifyError(UserNotifierImpl.java:291)
	at org.openmicroscopy.shoola.env.AbnormalExitHandler.doTermination(AbnormalExitHandler.java:147)
	at org.openmicroscopy.shoola.env.AbnormalExitHandler.terminate(AbnormalExitHandler.java:85)
	at org.openmicroscopy.shoola.env.RootThreadGroup.uncaughtException(RootThreadGroup.java:69)
	at java.awt.EventDispatchThread.processException(EventDispatchThread.java:264)
	at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:256)
	at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:161)
	at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:150)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:146)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:138)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:91)

[rkferguson]

Attached log with all of today's sessions in it to ticket as it seemed to have more than the error message did.

[dlindner]

Fixed by ​https://github.com/openmicroscopy/openmicroscopy/commit/9074e13732da90230b2f76c2836fe3e85d0b7406