Bug: Error after adding new user to rw group

[pwalczysko]

Created a new read-write group. Then couple of times downgraded the group to read-annotate as owner (non-admin). Then again upgraded the group to read-write (as admin). Alternately using Insight and Web for the up and downgrades. Then, as an owner-not-admin I was adding a new user to this (now again) rw group. Error occured.

Traceback (most recent call last):

  File "/opt/hudson/workspace/OMERO-5.1-latest-deploy/src/dist/lib/python/django/core/handlers/base.py", line 114, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)

  File "/opt/hudson/workspace/OMERO-5.1-latest-deploy/src/dist/lib/python/omeroweb/decorators.py", line 471, in wrapped
    retval = f(request, *args, **kwargs)

  File "/opt/hudson/workspace/OMERO-5.1-latest-deploy/src/dist/lib/python/omeroweb/decorators.py", line 521, in wrapper
    context = f(request, *args, **kwargs)

  File "/opt/hudson/workspace/OMERO-5.1-latest-deploy/src/dist/lib/python/omeroweb/webadmin/views.py", line 846, in manage_group_owner
    context['userId'] = userId

UnboundLocalError: local variable 'context' referenced before assignment


<WSGIRequest
path:/latest/webadmin/group_owner/save/1203/,
GET:<QueryDict: {}>,
POST:<QueryDict: {u'csrfmiddlewaretoken': [u'CFDjgGaVwzFkmVwBxRDBt0OMRe1ClEx4'], u'owners': [u'10'], u'members': [u'102', u'53', u'2', u'10', u'423']}>,
COOKIES:{'_ga': 'GA1.2.483423307.1416590819',
 'csrftoken': 'CFDjgGaVwzFkmVwBxRDBt0OMRe1ClEx4',
 'phpbb3_a9mfv_k': '6b796a78233f1705',
 'phpbb3_a9mfv_sid': '9ee0fd5b5754a1c7ec9a086325230bad',
 'phpbb3_a9mfv_u': '2759',
 'sessionid_latest': 's0iytub7ltb53b32wqpg7z2wh1mplsch',
 'style_cookie': 'null'},
META:{'CONTENT_LENGTH': '118',
 'CONTENT_TYPE': 'application/x-www-form-urlencoded',
 u'CSRF_COOKIE': u'CFDjgGaVwzFkmVwBxRDBt0OMRe1ClEx4',
 'HTTPS': 'on',
 'HTTP_ACCEPT': 'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8',
 'HTTP_ACCEPT_ENCODING': 'gzip, deflate',
 'HTTP_ACCEPT_LANGUAGE': 'en-GB,en;q=0.5',
 'HTTP_CONNECTION': 'keep-alive',
 'HTTP_CONTENT_LENGTH': '118',
 'HTTP_CONTENT_TYPE': 'application/x-www-form-urlencoded',
 'HTTP_COOKIE': 'phpbb3_a9mfv_u=2759; phpbb3_a9mfv_k=6b796a78233f1705; phpbb3_a9mfv_sid=9ee0fd5b5754a1c7ec9a086325230bad; style_cookie=null; csrftoken=CFDjgGaVwzFkmVwBxRDBt0OMRe1ClEx4; _ga=GA1.2.483423307.1416590819; sessionid_latest=s0iytub7ltb53b32wqpg7z2wh1mplsch',
 'HTTP_HOST': 'trout.openmicroscopy.org',
 'HTTP_REFERER': 'https://trout.openmicroscopy.org/latest/webadmin/group_owner/edit/1203/',
 'HTTP_USER_AGENT': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:33.0) Gecko/20100101 Firefox/33.0',
 'PATH_INFO': u'/webadmin/group_owner/save/1203/',
 'QUERY_STRING': '',
 'REQUEST_METHOD': 'POST',
 'SCRIPT_INFO': '/latest',
 'SCRIPT_NAME': u'/latest',
 'SERVER_NAME': 'ome-c6100-3',
 'SERVER_PORT': '443',
 'SERVER_PROTOCOL': 'HTTP/1.1',
 'wsgi.errors': <flup.server.fcgi_base.TeeOutputStream object at 0x3e2f650>,
 'wsgi.input': <flup.server.fcgi_base.InputStream object at 0x3e2f250>,
 'wsgi.multiprocess': True,
 'wsgi.multithread': False,
 'wsgi.run_once': False,
 'wsgi.url_scheme': 'https',
 'wsgi.version': (1, 0)}>

Filing as a blocker, we might judge otherwise after wmoore investigates deeper.

[wmoore]

Fixed in ​https://github.com/openmicroscopy/openmicroscopy/pull/3845