Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #13096 (new)

Opened 4 years ago

Last modified 4 years ago

omero.web.apps should be unique

Reported by: atarkowska Owned by: atarkowska
Priority: major Milestone: Unscheduled
Component: Web Version: OMERO-5.2.0
Keywords: n.a. Cc: wmoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

bin/omero config append allows to add multiple omero.web.apps that cause

django.core.exceptions.ImproperlyConfigured: Application labels aren't unique, duplicates: figure

This should be SET to guarantee they are unique

Change History (4)

comment:1 Changed 4 years ago by atarkowska

  • Cc wmoore added

comment:2 Changed 4 years ago by jburel

  • Milestone changed from OMERO-5.2.1 to OMERO-5.2.2

Milestone OMERO-5.2.1 deleted

comment:3 Changed 4 years ago by jburel

  • Milestone changed from OMERO-5.2.2 to OMERO-5.2.1

Milestone OMERO-5.2.2 deleted

comment:4 Changed 4 years ago by sbesson

In https://github.com/openmicroscopy/openmicroscopy/blob/v5.2.1/components/tools/OmeroPy/src/omero/plugins/prefs.py#L357, it should be sufficient to have something along the lines of

config[args.KEY] = json.dumps(list(set(list_value)))

with the corresponding unit tests. Is there any situation where a property should accept duplicates or rely on the list order and this change would be breaking?

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.310173 sec.)

We're Hiring!