Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #1321 (closed)

Opened 15 years ago

Closed 15 years ago

Last modified 13 years ago

Improve script params handling

Reported by: jamoore Owned by: jamoore
Priority: major Milestone: OMERO-Beta4.2
Component: Scripting Version: 3.0-M1
Keywords: n.a. Cc: jburel, wmoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: n.a.

Description (last modified by jburel)

  • Add param types: see ​insight#1135
  • Processor.processJob() should not call parseJob() This has unnecessary overhead (i.e. slow). Params should be cached. Options:
    • New DB table
    • New DB column
    • Freeze or other AlternativeStorage mechanism
    • Original file attached by annotation
    • Original file attached by convention
    • Original file attached by job
  • Detect changed params
  • Can't get session for cleanup printed on parseJob

Change History (30)

comment:1 Changed 15 years ago by jmoore

  • Component changed from General to Scripting
  • Owner changed from jmoore to dzmacdonald

comment:2 Changed 15 years ago by jmoore

  • Owner changed from dzmacdonald to jmoore

comment:3 Changed 15 years ago by jmoore

  • Type changed from Bug to Task

comment:4 Changed 15 years ago by jmoore

  • Remaining Time set to 2

comment:5 Changed 15 years ago by jmoore

  • Status changed from new to assigned

comment:6 Changed 15 years ago by jmoore

  • Description modified (diff)
  • Summary changed from Processor.processJob() should not call parseJob() to Improve script params handling

comment:7 Changed 15 years ago by jmoore

  • Cc jburel wmoore added
  • Description modified (diff)

comment:8 Changed 15 years ago by jmoore

  • Description modified (diff)

comment:9 Changed 15 years ago by jmoore

  • Description modified (diff)

comment:10 Changed 15 years ago by jburel

  • Description modified (diff)

comment:11 Changed 15 years ago by jmoore

(In [6251]) see #1321 - initial storage of JobParams as original file and ScriptI refactoring

  • Removed runScripts
  • Return JobParams from getParams
  • Added editScript
  • Added Callback2 and safeRunnableCall
  • Caching format objects in ScriptI
  • Removed temp jobs
  • Temporary disabling job message setting

comment:12 Changed 15 years ago by jmoore

(In [6252]) see #1321 - Adding min, max, etc to Params

comment:13 Changed 15 years ago by jmoore

(In [6253]) see #1321 - initial work on bin/omero script params command

comment:14 Changed 15 years ago by jmoore

(In [6254]) see #1321 - work on omero.scripts.Type incl. allowing Params

comment:15 Changed 15 years ago by jmoore

(In [6255]) see #1321 - converting other ScriptI methods to safeRunnableCall

comment:16 Changed 15 years ago by jmoore

(In [6256]) see #1321 - improving error handling for safeRunnableCall

comment:17 Changed 15 years ago by jmoore

(In [6257]) see #1321 - Adding bulk session getters for inputs/outputs

comment:18 Changed 15 years ago by jmoore

(In [6258]) see #1321 - passing JobParams into Processor.processJob()

comment:19 Changed 15 years ago by jmoore

(In [6260]) see #1321 - Added omero.rtypes.unwrap for use in inputs/outputs

comment:20 Changed 15 years ago by jmoore

(In [6261]) see #1321 - reducing invocations to parseJob

comment:21 Changed 15 years ago by jmoore

(In [6262]) see #1321 - Adding bin/omero script demo for testing (also work on delete/launch)

comment:22 Changed 15 years ago by jmoore

(In [6263]) see #1321 - Now uploading stdout/stderr for parse jobs

comment:23 Changed 15 years ago by jmoore

(In [6264]) see #1321 - Addition of omero.model.ParseJob subclass and ParamsHelpers

comment:24 Changed 15 years ago by jmoore

(In [6266]) see #1321 - Added omero.rtypes.wrap

comment:25 Changed 15 years ago by jmoore

(In [6267]) see #1321 - Improved params, validation, demo and various other fixes (logging, etc.)

comment:26 Changed 15 years ago by jmoore

  • Remaining Time changed from 2 to 0
  • Resolution set to fixed
  • Status changed from assigned to closed

(In [6269]) fix #1321 - Various fixes and demo for testing.

comment:27 Changed 15 years ago by jmoore

(In [6273]) see #1321 - Fixing runHelloWorld.py

comment:28 Changed 14 years ago by jmoore

(In [6302]) see #1321,#1952 - Removing Params.name. Redundant with map key.

comment:29 Changed 13 years ago by jmoore <josh@…>

(In [f590801472ccc2abd22155c026c21d6fec37f6df/ome.git] on branch dev_4_1_custom) see #1321 - Added omero.rtypes.unwrap for use in inputs/outputs

git-svn-id: ​file:///home/svn/omero/trunk@6260 05709c45-44f0-0310-885b-81a1db45b4a6

comment:30 Changed 13 years ago by jmoore <josh@…>

(In [5661f83a639bd7f2fcf5b1b0797be3439d8544c1/ome.git] on branch dev_4_1_custom) see #1321 - Added omero.rtypes.wrap

git-svn-id: ​file:///home/svn/omero/trunk@6266 05709c45-44f0-0310-885b-81a1db45b4a6

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.67554 sec.)

© 2000-2014 University of Dundee & Open Microscopy Environment. Creative Commons Attribution 3.0 Unported License
OME source code is available under the GNU General public license or through commercial license from Glencoe Software

We're Hiring!