Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #13223 (closed)

Opened 8 years ago

Closed 8 years ago

Bug: file attachments with same name overwritten

Reported by: khgillen Owned by: dlindner
Priority: critical Milestone: Unscheduled
Component: General Version: OMERO-5.2.2
Keywords: n.a. Cc: ux@…
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description (last modified by khgillen)

Using Mac Insight 5.2.2 against Nightshade 5.2.2 release.

*preparation*
Have 2 files with the same name, in different folders.
Make an obvious change to the files.

e.g.

LS27172:nstest kenny$ mkdir subfolder
LS27172:nstest kenny$ echo "contents 1" > contents1.txt
LS27172:nstest kenny$ echo "contents 2" > subfolder/contents1.txt

Navigate via Projects
Click any image.

In r.h. panel click + for 'attachments'
Choose 'local document'
Pick the first file, and allow it to upload.

In the RH panel, in file attachments, click the button to the right of the uploaded file (1), and choose 'View'.

Expected: you should see the contents of file 1.

In r.h. panel click + for 'attachments'
Choose 'local document'
Pick the second file (same filename as file 1!), and allow it to upload.

Expected NO second file appears in the RH panel for 'Attachments'.

In the RH panel, in file attachments, click the button to the right of the uploaded file, and choose 'View'.

Expected: the contents of the existing file have now been replaced by the contents of the second file.

NOTE:

I feel this could be dangerous if users have a workflow which uses some intermediate tool in the chain which produces a file with name like results.csv. If a user were to attempt to upload results.csv on the wrong image, the original set of results would be overwritten.

Though this is, of course, a made-up workflow, and may not affect any actual users.

Change History (4)

comment:1 Changed 8 years ago by khgillen

  • Description modified (diff)

comment:2 Changed 8 years ago by jburel

  • Priority changed from minor to critical

I thought the problem was fixed.
Bumping priority

comment:3 Changed 8 years ago by dlindner

  • Owner changed from jburel to dlindner

comment:4 Changed 8 years ago by dlindner

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.92107 sec.)

We're Hiring!