saveObject(unloadedObject) with settings leads to dirty session if perms are not rw-----

[jamoore]

IUpdate.save/AndReturnObject(image) when ObjectSettings are non-null lead to strange session exceptions.

[jmoore]

Not reproducible in 4.1

[jmoore]

This is related to permissions. Objects which have group-read are locked by OmeroInterceptor:

    public void markLockedIfNecessary(IObject iObject) {
...
            if (!sysTypes.isSystemType(object.getClass())) {
                Permissions p = object.getDetails().getPermissions();
                if (p.isGranted(Role.GROUP, Right.READ)
                        || p.isGranted(WORLD, READ)) {
...

Looking into a workaround which detects the unloaded objects.

Note: a secondary issue which may need its own ticket - Locking is happening repeatedly:

josh@mac:/tmp/detectors$ grep "Locking object" error2.log | cut -b100- | sort | uniq -c
  13 t: ome.model.acquisition.DetectorSettings:Id_7078
  28 t: ome.model.annotations.CommentAnnotation:Id_9588
  28 t: ome.model.core.Channel:Id_20953
  22 t: ome.model.core.LogicalChannel:Id_20953

[jmoore]

This is reproducible in 4.1.x, but only with non-default permissions (i.e. something other than rw----)

r5903 (trunk), r5904 (b_4_1), and r5905 (b_4_0) contain an initial fix for this. There seem to be other issues with locking. Opened #1698 as a follow-up.