Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Bug #1486 (closed)

Opened 15 years ago

Closed 15 years ago

Revert some changes in importer gui commit 5092

Reported by: jamoore Owned by: bwzloranger
Priority: critical Cc:
Sprint: n.a.
Total Remaining Time: n.a.

Description

r5092 will lead to new bugs.

Specifically, no call should be made to reader after an exception (see line 327). Instead, a null should be passed back, and FileQueueHandler should do something with the event.

Change History (3)

comment:1 Changed 15 years ago by jmoore

r5108 reverts to returning null. Returning a fake import container breaks directory import as well, since the detecting of isSPW() can never be completely right. This leads to an GUI exception "you've chosen both SPW and non-SPW images, please choose only one" making it useless. I'm reverting to returning null, which will prevent the path from showing up in the queue. (It was showing up in the queue as "added" anyway, rather than as "failed" as discussed)

Options:

  • get rid of the restriction SPW or not SPW. This is a major workflow change
  • don't worry about the return value and handle the SCANNING_FILE_EXCEPTION from all handlers (as discussed)
  • using a FailedImportContainer (I'm not sure what all this entails)
  • ...

comment:2 Changed 15 years ago by bwzloranger

  • Milestone changed from OMERO-Beta4.1 to OMERO-Beta4.2

comment:3 Changed 15 years ago by bwzloranger

  • Resolution set to fixed
  • Status changed from new to closed

This problem is solved now by having failed candidates go directly to the failed imports queue and presenting a popup. This bypasses the normal import queue entirely.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.62016 sec.)

We're Hiring!