Implement "System-Types" (Experimenter,Event,...) which can't be created by all users.

[jamoore]

It was assumed that ITypes' functionality was needed to implement System-Types, but it should be doable with a single interface (ome.api.SystemTypes). This can then be implemented before the DSL is ported to annotations (#96). In combination with the change made for #52 (allowing annotations from different users when running as root), we are approaching the basic building stones needed for Security.

[jmoore]

Another requirement for System-Types may be that instances are also not editable by users regardless of the other Permissions set. Such a use case exists in the Rendering Engine where there should be no alterations of the rendering settings through IUpdate or other mechanisms. RenderingBean? can use a @RunAs? annotation to set the current role to "system", so that system types can be edited.

This could be solved through a different mechanism and then the System-Types feature remains quite simple.

[jmoore]

This is at the basis of much of our security. Let's get it done soon.

[jmoore]

Not just the non-creation but also the updating of System-Types can be controlled. This should be added to UpdateFilter & SecuritySystem such that no time is spent trying to verify updates to, e.g., Experimenter (a la checkManagedState), rather that it simply passes through and if it ends up in an UpdateEvent then an exception is thrown.

[jmoore]

r768 added the definition of SystemTypes (even if this needs to be moved to ITypes), but the actual catching of their creation/update still needs work. Most of iteration1 was spent preparing for these catches, by pushing the checks on transient and managed object (specifically their details) into the Hibernate EventListeners rather than in UpdateFilter, which turned out to be extremely tricky, requiring the addition of the findDirty check in OmeroInterceptor.

Planning on pushing this to the next iteration.

[jmoore]

r790 introduces several tests that check System-Types. Looking good.

[jmoore]

With the changes of r812 and r827 System-Types are fully implemented. From the server side, there are some issues with when the objects get created as whom, but that is less of a concern. Clients can no longer create the security-related types ( Experimenter, ExperimenterGroup, GroupExperimenterMap, Event,...) nor IEnums (#157). This is all now checked in the ACLEventListener.