Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

User Story #159 (closed)

Opened 13 years ago

Closed 13 years ago

getImages method is broken

Reported by: cxallan Owned by: jamoore
Priority: blocker Milestone: 3.0-M2
Component: API Keywords: iteration4
Cc: jburel Story Points: n.a.
Sprint: n.a. Importance: n.a.
Total Remaining Time: n.a. Estimated Remaining Time: n.a.

Description

In the IPojos service, the getImages() method appears to be broken. It returns objects corresponding to the "class" and "ids" passed. :)

For example:

package ome.client.itests;

import org.testng.annotations.*;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Set;

import junit.framework.TestCase;

import ome.api.IPojos;
import ome.model.containers.Dataset;
import ome.system.ServiceFactory;

@Test( 
	groups = {"client","integration"} 
)
public class GetImagesTest extends TestCase
{

    ServiceFactory sf = new ServiceFactory();

  @Test
    public void test_withLogin() throws Exception
    {
       	IPojos iPojos = sf.getPojosService();
       	Set ids = new HashSet();
       	ids.add(new Long(1));
       	ids.add(new Long(2));
       	Set images = iPojos.getImages(Dataset.class, ids, new HashMap());
       	
       	for (Object o : images)
       	{
       		System.err.println("Object: " + o);
       	}
    }
}

Results in:

Object: Dataset:Id_1
Object: Dataset:Id_2

Change History (2)

comment:1 Changed 13 years ago by jmoore

  • Keywords iteration4 added
  • Milestone changed from Unscheduled to cycle1
  • Status changed from new to assigned

comment:2 Changed 13 years ago by jmoore

  • Cc jburel added
  • Resolution set to fixed
  • Status changed from assigned to closed

r723 fixes this. The getImages query was walking up from the given ids rather than walking down. Test going along with this is fairly extensive but missing groups. We will need to add these back at some point.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.76750 sec.)

We're Hiring!