Importer feedback gets into weird loop

[jamoore]

See:

• ​http://qa.openmicroscopy.org.uk/qa/feedback/1684/
• ​http://qa.openmicroscopy.org.uk/qa/feedback/1685/
• ​http://qa.openmicroscopy.org.uk/qa/feedback/1686/
• ​http://qa.openmicroscopy.org.uk/qa/feedback/1687/

What I did:

• Added one plate to the queue.
• Did a larger directory scan
• Single import failed, and moved on to the other imports
• I tried to send the single failure
• Didn't seem to do anything. (I filed ticket #1668 manually)
• Another image failed, I didn't say "send" but it was sent anyway (see above)
• Says "done" for first error, not for second, and "Send feedback" button is turned off

Eventually I get this:

Ice.CommunicatorDestroyedException
	at IceInternal.Instance.objectAdapterFactory(Instance.java:122)
	at Ice.ObjectPrxHelperBase.createDelegate(ObjectPrxHelperBase.java:997)
	at Ice.ObjectPrxHelperBase.__getDelegate(ObjectPrxHelperBase.java:946)
	at omero.api.MetadataStorePrxHelper.createRoot(MetadataStorePrxHelper.java:46)
	at omero.api.MetadataStorePrxHelper.createRoot(MetadataStorePrxHelper.java:20)
	at ome.formats.OMEROMetadataStoreClient.createRoot(OMEROMetadataStoreClient.java:500)
	at ome.formats.importer.ImportLibrary.importImage(ImportLibrary.java:508)
	at ome.formats.importer.gui.ImportHandler.importImages(ImportHandler.java:182)
	at ome.formats.importer.gui.ImportHandler.access$100(ImportHandler.java:45)
	at ome.formats.importer.gui.ImportHandler$2.run(ImportHandler.java:97)
	at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
	at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source)
	at java.util.concurrent.FutureTask.run(Unknown Source)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(Unknown Source)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.lang.Thread.run(Unknown Source)
2009-11-17 09:04:45,916 5648235    [2-thread-1] ERROR  importer.gui.ErrorHandler$MyErrorHandler  - Error while sending error information.
2009-11-17 09:05:19,136 5681455    [2-thread-1] ERROR  importer.gui.ErrorHandler$MyErrorHandler  - Error while sending error information.

and importer is stuck with:

"analyzing the metadata for file "..." (file 3 of 7 imports)

(even though there are 8 imports)

[bwzloranger]

Haven't been able to duplicate this error (plates were importing ok even during directory scanning!). Perhaps this is a concurrency issue generated by bio-formats when trying to access it twice.

Will investigate further and make some make some adjustments to error handler to try and handle the odd 'off by one' error that seems to be happening.

[bwzloranger]

Cleaned up some feedback code which will hopefully help.