Rework logging to use varargs and to silence test output.

[jamoore]

Now that /common and /client are compiling with Java5 (#154) all references to Commons Logging (private static Log log = Logger...) should be replaced by an internal Log class similar to that in ​Stripes using varargs to prevent the toString() overhead.

While doing this, all tests should be fixed to use logging as well. Depending on what our Log/LogFactory? solution looks like, something along the lines of :

  private static Log TESTLOG = LogFactory.testLogger(MyTest.class);
  // equivalent to
  // TESTLOG = LogFactory.logger("TEST-"+MyTest.class.getName());

That way, all testing could be turned off with:

  log4j.category.TEST = error

or redirected to a file.

[jmoore]

"TEST-"<classname> log4j categories won't suffice. Obviously, the tests are calling lots of methods which use the real loggers. Probably the only solution for the test output is a log4j.test_properties file which gets copied to target/classes during testing.

[jmoore]

In addition, we may should start injecting loggers to avoid statics. See: ​http://wiki.apache.org/jakarta-commons/Logging/StaticLog for more.

[jamoore]

with SLF4J this is now done.