Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #1801 (closed)

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

Thumbnail / Rendering will need to be permissions-aware

Reported by: jamoore Owned by: cxallan
Priority: major Milestone: OMERO-Beta4.2
Component: Security Version: 4.1
Keywords: n.a. Cc: atarkowska, jburel, wmoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2010-03-19 (5)

Description

​shoola:ticket:1157 and ticket:1769 describe issues when admins or PIs try to interact with a private group. r6106 had an initial fix for some of the ThumbnailStore and RenderingEngine methods, but there are several other code paths which also try to create objects, which will need similar handling, e.g. getThumbnailByLongestSideSet() which is used heavily from Insight.

This ticket is a part of #1434

Change History (12)

comment:1 Changed 9 years ago by jmoore

  • Cc atarkowska jburel added

r6108 has a working getThumbnailByLongestSideSet. Chris, review to you. Jean-Marie, you should be good to test.

comment:2 Changed 9 years ago by cxallan

  • Remaining Time set to 1.0
  • Sprint set to 2009-02-19 (3)
  • Status changed from new to assigned

Taking this on now as a thumbnail store refactoring.

comment:3 Changed 9 years ago by cxallan

  • Remaining Time changed from 1.0 to 1
  • Summary changed from Permissions : Thumbnail / Rendering will need to be permissions-aware to Thumbnail / Rendering will need to be permissions-aware

comment:4 Changed 9 years ago by cxallan

r6160 had an initial version and r6165 has the fleshed out and ported thumbnail bean.

comment:5 Changed 9 years ago by cxallan

r6201 fixes a couple small bugs and ensures that all the RenderingSessionTest tests pass.

comment:6 Changed 9 years ago by cxallan

  • Remaining Time changed from 1 to 0
  • Resolution set to fixed
  • Status changed from assigned to closed

Should be complete with nicer exception messages in r6202.

comment:7 Changed 9 years ago by cxallan

(In [6222]) Unit tests for other usage. Fixed a bug preventing first time settings reset. (See #1801)

comment:8 Changed 9 years ago by cxallan

(In [6223]) Slightly more reasonable exception message and test case fix. (See #1801)

comment:9 Changed 9 years ago by cxallan

  • Cc wmoore added
  • Remaining Time changed from 0 to 0.25
  • Resolution fixed deleted
  • Sprint changed from 2010-02-19 (3) to 2010-03-19 (5)
  • Status changed from closed to reopened

Re-opened to take a look at the affects of the new read-only group semantics on the RenderingEngine.

comment:10 Changed 9 years ago by cxallan

  • Remaining Time changed from 0.25 to 0
  • Resolution set to fixed
  • Status changed from reopened to closed

comment:11 Changed 9 years ago by cxallan

(In [6406]) Resolved issues with creating a rendering engine in a read-only group for another users Pixels set. (Fixes #1801)

comment:12 Changed 9 years ago by cxallan

Also added test cases for rendering engine usage in r6406.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.122291 sec.)

© 2000-2014 University of Dundee & Open Microscopy Environment. Creative Commons Attribution 3.0 Unported License
OME source code is available under the GNU General public license or through commercial license from Glencoe Software

We're Hiring!