Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #218 (closed)

Opened 15 years ago

Closed 12 years ago

Rendering tests need an ImportFixture

Reported by: jamoore Owned by: cxallan
Priority: major Milestone: OMERO-Beta4
Component: Bin-Services Version: n.a.
Keywords: rendering, testing Cc: bwzloranger
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

RenderingEngineTest will always fail because there are no valid rendering defs in the DB. A fixture to create one is needed.

Change History (10)

comment:1 Changed 15 years ago by jmoore

r772 sets the test to broken until we get this fixed.

comment:2 Changed 15 years ago by jmoore

  • Cc brain added
  • Milestone changed from Unscheduled to 3.0-M3
  • Priority changed from minor to major

Since I can't attached I've uploaded all the following to :
http://users.openmicroscopy.org.uk/~jmoore/bioformats-omero/

For testing #258 I needed pixels in the db (otherwise RE always explodes). So I went ahead and did some work on this:

  • import-library-patch.txt reworks ImportHandler, OMEROMetadaStore, and ImportDialog to make testing easier.
  • bioformats-omero.zip contains several new files (and some test data from OME-WEBSITE/TestImages) that are needed to make the patch work:
    • ImportLibrary factors the non-Gui code out of ImportHandler so it can be used standable.
    • ImportFixture is basically the non-Gui replacement for ImportHandler which can be used from test cases
    • and ExampleUnitTest uses those along with the tinyTest.d3d.dv image
    • The other top-level files are to get bioformats-omero into the build system. This was tested on trunk, and if you drop all the zip contents under /components it should work, if...
  • build-changes.patch is also applied. It should be applied from OMERO_HOME.

comment:3 Changed 15 years ago by jmoore

With r1013 /branches/bioformats-omero is svn:externaled to /trunk/components/bioformats-omero This was necessary for me to do any (non-manual) testing on #410.

Two things:

  • It'd be good to have the branch ported and get rid of the svn:external
  • It'd be good to move the packages out of the /branches or /trunk
    and to something like /packages

The one example integration test under /bioformats-omero passes.

comment:4 Changed 15 years ago by jmoore

r1014 makes the necessary changes to the branch. The branch is svn:externaled as http for the moment (no write access) so modifications will have to be made there.

comment:5 Changed 15 years ago by cxallan

  • Keywords iteration1 added
  • Milestone changed from 3.0-M3 to 3.0-M4
  • Version changed from 3.0-M3 to 3.0-M4

Re-scheduling to milestone 4.

comment:6 Changed 15 years ago by jmoore

r1035 makes server-side ThumbnailServiceTest a bit more robust after seeing the first (intermittent) failure. Need to get rid of ObjectFactory.createPixels() and ObjectFactory.createRenderingDef() like methods and only use real import fixtures.

comment:7 Changed 15 years ago by jmoore

r1036 gives it another shot, but r1037 just marks this test as broken. Will have to refactor things around to let the server use importer. One possibility is to simply make server dependent on client, but that makes integration testing scary. Best choice is probably:

  • client->importer
  • importer->common
  • server->importer

Though this makes testing directly in importer difficult (similar to /romio tests which are under /server)

comment:8 Changed 14 years ago by cxallan

  • Keywords iteration1 removed
  • Milestone changed from 3.0-Beta2 to 3.0-Beta3
  • Status changed from new to assigned
  • Version 3.0-Beta1 deleted

comment:9 Changed 13 years ago by cxallan

  • Milestone changed from 3.0-Beta3 to 3.0-Beta4

comment:10 Changed 12 years ago by cxallan

  • Resolution set to fixed
  • Status changed from assigned to closed

The test engine and other additions largely resolve this. Re-open as necessary.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.63673 sec.)

We're Hiring!