Task #2206 (closed)
Opened 9 years ago
Closed 9 years ago
Implement schema changes
| Reported by: | jamoore | Owned by: | jamoore |
|---|---|---|---|
| Priority: | minor | Milestone: | OMERO-Beta4.2 |
| Component: | Model | Version: | n.a. |
| Keywords: | n.a. | Cc: | ajpatterson, jburel |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2010-04-16 (7) |
Description (last modified by jburel)
After a discussion with Andrew, the schema changes which need to get propagated to the db are:
- Roi.theC (removal of the logic channel link)
- text becomes label (be sure to upgrade discriminators)
- Plate acquisition: name (opt), description, well samples, MaximumFieldCount?
- Channel.lightPath, no secondaries
- Excitation/Emissions? filter list (needs optical element)
See insight#1367
Change History (4)
comment:1 Changed 9 years ago by jmoore
- Description modified (diff)
comment:2 Changed 9 years ago by wmoore
comment:3 Changed 9 years ago by jburel
- Description modified (diff)
comment:4 Changed 9 years ago by jmoore
- Remaining Time changed from 0.5 to 0
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
From Nitpick e-mail about Filters...
Easiest upgrade solution that Andrew suggested is that we simply move "SecondaryEmissionFilters?" etc into LightPath?, and don't touch anything in FilterSets?.
However, this means that metadata imported from a particular file before the filter update (and subsequently transformed to the new model) will not match the metadata from the same file imported after the filter update. If imported before update, Dichroic will be in a FilterSet? on Channel, and if imported after update, Dichroic will be in LightPath? on Channel.
Slightly better (more complex) solution is to move "SecondaryEmissionFilters?" etc into LightPath? (as above) but ALSO put the Dichroic and Primary EmissionFilters? from FilterSet? into LightPath? (so they are linked to Channel by FilterSet? AND LightPath?). This would mean that all the filters known to be used for a particular Channel are in LightPath?, which is how LightPath? is intended to be used.
In the small number of cases where we might have Emission/Excitation? Filters in FilterSet? AND Secondary Emission/Excitation? Filters, it would be nice to preserve the order in LightPath?, E.g.
ExcitationFilter? (from SecondaryExcitationFilter?
ExcitationFilter? (from FilterSet?)
Dichroic (from FilterSet?)
EmissionFilter? (from FilterSet?)
EmissionFilter? (from SecondaryEmissionFilter?)
This would mean that LightPath? is fully populated with acquisition filters regardless of whether a file was imported before or after the filter upgrade.