BUG: getScripts() NPE

[wmoore]

    params = scriptService.getParams(id)
  File "/Users/will/Documents/workspace/Omero/dist/lib/python/omero_api_IScript_ice.py", line 137, in getParams
    return _M_omero.api.IScript._op_getParams.invoke(self, ((scriptID, ), _ctx))
omero.InternalException: exception ::omero::InternalException
{
    serverStackTrace = java.lang.NullPointerException
	at omero.grid.ParamsHelper.generateScriptParams(ParamsHelper.java:144)
	at omero.grid.ParamsHelper.getOrCreateParams(ParamsHelper.java:102)
	at ome.services.blitz.impl.ScriptI$9.call(ScriptI.java:329)
	at ome.services.throttling.Callback2.run(Callback2.java:49)
	at ome.services.throttling.InThreadThrottlingStrategy.safeRunnableCall(InThreadThrottlingStrategy.java:80)
	at ome.services.blitz.impl.AbstractAmdServant.safeRunnableCall(AbstractAmdServant.java:151)
	at ome.services.blitz.impl.ScriptI.getParams_async(ScriptI.java:327)
	at omero.api._IScriptTie.getParams_async(_IScriptTie.java:78)
	at omero.api._IScriptDisp.___getParams(_IScriptDisp.java:340)
	at omero.api._IScriptDisp.__dispatch(_IScriptDisp.java:461)
	at IceInternal.Incoming.invoke(Incoming.java:159)
	at Ice.ConnectionI.invokeAll(ConnectionI.java:2037)
	at Ice.ConnectionI.message(ConnectionI.java:972)
	at IceInternal.ThreadPool.run(ThreadPool.java:577)
	at IceInternal.ThreadPool.access$100(ThreadPool.java:12)
	at IceInternal.ThreadPool$EventHandlerThread.run(ThreadPool.java:971)

    serverExceptionClass = java.lang.NullPointerException
    message = 
}

[wmoore]

(In [6768]) This demonstrates the bug: See #2289.

Run test
test/integration/scripts.py TestScripts?.testParseErrorTicket218

[wmoore]

Sorry, that should be test (run from OmeroPy)

$ python test/integration/scripts.py TestScripts.testParseErrorTicket2185

[jmoore]

(In [6774]) fix #2289 - cleaner use of ServantHolder

In some cases, a stringified-Ice.Identity was being
passed to ServantHolder. This refactors several uses
and simplifies unwrapping Tie servants.