Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #2309 (closed)

Opened 14 years ago

Closed 14 years ago

UserScripts should ONLY run on User-Processor

Reported by: wmoore Owned by: jamoore
Priority: minor Milestone: OMERO-Beta4.2
Component: General Version: n.a.
Keywords: n.a. Cc:
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2010-04-30 (8)

Description (last modified by wmoore)

If a user uses scriptService.uploadScript("path", script) to upload a script, this should be considered an "Unofficial" script and should require a user-processor to run, even if uploaded by an admin.

Test: TestScripts?.testRunScript committed below, fails because script can be run by root.

Change History (10)

comment:1 Changed 14 years ago by wmoore

(In [6817]) See #2309. Test fails because 'unoffical' script runs without requiring user-processor.

comment:2 Changed 14 years ago by wmoore

  • Description modified (diff)
  • Owner set to jmoore

comment:3 Changed 14 years ago by jmoore

  • Status changed from new to assigned

comment:4 Changed 14 years ago by jmoore

  • Remaining Time set to 0
  • Resolution set to fixed
  • Status changed from assigned to closed

(In [6821]) fix #2309 - filtering non ScriptRepo scripts from validateScripts

comment:5 Changed 14 years ago by wmoore

(In [6825]) Test passes now. See #2309

comment:6 Changed 14 years ago by wmoore

(In [6826]) Test fails when root uploads official script and tries to run. See #2309.

comment:7 Changed 14 years ago by wmoore

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:8 Changed 14 years ago by jmoore

  • Status changed from reopened to new

comment:9 Changed 14 years ago by jmoore

  • Status changed from new to assigned

comment:10 Changed 14 years ago by jmoore

  • Resolution set to fixed
  • Status changed from assigned to closed

With rr6939 all tests in test/integration/scripts.py were passing.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.70531 sec.)

© 2000-2014 University of Dundee & Open Microscopy Environment. Creative Commons Attribution 3.0 Unported License
OME source code is available under the GNU General public license or through commercial license from Glencoe Software

We're Hiring!