Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #2551 (closed)

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

BUG: populateroi.py moved out of omero/ directory

Reported by: jamoore Owned by: wmoore
Priority: blocker Milestone: OMERO-Beta4.2
Component: Scripting Version: n.a.
Keywords: n.a. Cc: jburel, cxallan
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2010-06-24 (12)

Description (last modified by jmoore)

I'm not sure if it was intentional, but populateroi.py seems to have been deleted.

commit c2ddf12d661ada474ab8befa7d96ad9a2e527040
Author: wmoore <wmoore@05709c45-44f0-0310-885b-81a1db45b4a6>
Date:   Fri May 28 11:38:27 2010 +0000

    call closeSession at end of each script. Closes #2404.
    
    
    git-svn-id: file:///home/svn/omero/trunk@7124 05709c45-44f0-0310-885b-81a1db45b4a6

 .../scripts/omero/export_scripts/Make_Movie.py     |    1 +
 .../scripts/omero/figure_scripts/Movie_Figure.py   |    9 +++---
 .../scripts/omero/figure_scripts/Roi_Figure.py     |    8 +++--
 .../omero/figure_scripts/Roi_Movie_Figure.py       |    8 +++--
 .../omero/figure_scripts/Split_View_Figure.py      |    7 +++--
 .../omero/figure_scripts/Thumbnail_Figure.py       |    4 +-
 .../omero/region_scripts/populatePlateRoi.py       |   28 --------------------
 .../scripts/omero/util_scripts/Combine_Images.py   |   15 ++++++----
 .../scripts/omero/util_scripts/Images_From_ROIs.py |    1 +
 9 files changed, 32 insertions(+), 49 deletions(-)

Change History (6)

comment:1 Changed 14 years ago by jmoore

  • Cc jburel cxallan added
  • Component changed from General to Scripting
  • Description modified (diff)
  • Priority changed from minor to blocker
  • Summary changed from BUG: populateroi.py missing to BUG: populateroi.py moved out of omero/ directory

I found it under server/Populate_Roi.py. That's not going to work. Only the scripts under "omero" are registered, even for server use. At the moment, it's useless for anyone.

General note: renaming scripts is a breaking change. It's part of the API of these files.

comment:2 Changed 14 years ago by wmoore

Hmmm - I think I asked Chris whether this would break anything and seem to remember that it wasn't being used in it's current state?

I think the idea was that we didn't want it showing up in Insight, but maybe we need another strategy for that. Should I move it back into scripts/omero?

comment:3 Changed 14 years ago by wmoore

  • Status changed from new to assigned

comment:4 Changed 14 years ago by wmoore

  • Remaining Time set to 0
  • Resolution set to fixed
  • Status changed from assigned to closed

(In [7420]) Moving and renaming populate_roi script. Closes #2551

comment:5 Changed 14 years ago by wmoore

(In [7421]) Instead of renaming 'region_scripts' delete it since it has no scripts. Deleting 'server' folder since it's not used. See #2551

comment:6 Changed 14 years ago by jmoore

(In [7439]) Updating Populate_ROI.py style and path info. (See #2551)

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.67544 sec.)

We're Hiring!