Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #2570 (new)

Opened 9 years ago

Last modified 4 years ago

Upgrade Hibernate

Reported by: jamoore Owned by: jballanco-x
Priority: critical Milestone: Unscheduled
Component: Services Version: 5.0.5
Keywords: n.a. Cc: jburel, cxallan
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.5d
Sprint: n.a.

Description (last modified by jmoore)

While preparing 4.2 (#1260), Hibernate released several patch versions.
And now after 4.3.3 Hibernate is at either:

See: http://in.relation.to/16459.lace

Change History (29)

comment:1 Changed 9 years ago by jmoore

  • Description modified (diff)
  • Summary changed from Upgrade to Hibernate 3.5.3 to Upgrade to Hibernate 3.5.4

comment:2 Changed 8 years ago by jmoore

Referencing ticket #1260 has changed sprint.

comment:3 Changed 8 years ago by jmoore

  • Component changed from General to Services
  • Description modified (diff)
  • Milestone changed from Unscheduled to OMERO-Beta4.4
  • Owner set to jmoore
  • Remaining Time set to 1.5
  • Sprint set to 2011-11-29 (3)
  • Status changed from new to accepted
  • Summary changed from Upgrade to Hibernate 3.5.4 to Upgrade Hibernate

comment:4 Changed 8 years ago by jmoore

Note: if we move to 4.0, then we could look at using multiple-tenancy as an improvement over our group-permissions. http://community.jboss.org/wiki/Multi-tenancyDesign

comment:5 Changed 8 years ago by jmoore

  • Sprint changed from 2011-11-29 (3) to 2011-12-13 (4)

Moved from sprint 2011-11-29 (3)

comment:6 Changed 8 years ago by jmoore

  • Cc jburel cxallan added
  • Remaining Time changed from 1.5 to 0.5

Note: 4.0 is still in CR (candidate for release) and is _quite_ the change. Although if 4.4 is very long-term, it might ultimately be to our advantage to be on hib4, but it could also put us somewhat farther behind. On the other hand hib3.6 is up to 3.6.8 and I'd imagine quite stable (comparatively). I have a patch that applies it; no code changes were needed, but I still need to do some preliminary testing.

comment:7 Changed 8 years ago by jmoore

Just ran into this:

Caused by: org.springframework.beans.BeanInstantiationException: Could not instantiate bean class [ome.tools.hibernate.SecurityFilter]: Constructor threw exception; nested exception is java.lang.NoSuchMethodError: org.hibernate.type.TypeFactory.heuristicType(Ljava/lang/String;)Lorg/hibernate/type/Type;
        at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:141)
        at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:107)
        at org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:273)
        ... 46 more
Caused by: java.lang.NoSuchMethodError: org.hibernate.type.TypeFactory.heuristicType(Ljava/lang/String;)Lorg/hibernate/type/Type;
        at org.springframework.orm.hibernate3.FilterDefinitionFactoryBean.setParameterTypes(FilterDefinitionFactoryBean.java:92)
        at ome.tools.hibernate.SecurityFilter.<init>(SecurityFilter.java:105)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)

See: http://forum.springsource.org/showthread.php?117701-Migrating-to-Spring-3-0-3-with-Hibernate-3-6-5

comment:8 Changed 8 years ago by jmoore

Fixed by upgrading to Spring 3.0.6.

Next issue: SoftLimitMRUCache

See: http://comments.gmane.org/gmane.comp.java.cdi.seam.issues/712

comment:9 Changed 8 years ago by jmoore

That was fixed by upgrading Hibernate search to 3.4.1 which brought along Lucene 3.1.0 which changed the ctor of QueryParser:

See: https://issues.apache.org/jira/browse/LUCENE-2002

comment:10 Changed 8 years ago by jmoore

Unexpected results during testing:

Bad query: Illegal query:select i from Image i where i.pixels.id = 352
illegal attempt to dereference collection [image0_.id.pixels] with element property reference [id] [select i from ome.model.core.Image i where i.pixels.id = 352]

On the other hand, the Java tests looked quite ok:

  [testng] ===============================================
  [testng] OmeroJava.integration
  [testng] Total tests run: 410, Failures: 2, Skips: 0
  [testng] ===============================================

and one of those is:

[testng] FAILED: testDowngradeTo201006ImageNoMetadata on instance null(integration.schema.Schema2011_06_TO_2010_06_Test)
  [testng] java.io.FileNotFoundException: /Users/andrew/Desktop/wibble1.xml (No such file or directory)

Search is likely quite broken since the indexer needs modification.

comment:11 Changed 8 years ago by jburel

The last test failure also happened in feature/reorganise_jar_new.

comment:12 Changed 8 years ago by jburel

  • Sprint changed from 2011-12-13 (4) to 2011-12-27 (5)

Moved from sprint 2011-12-13 (4)

comment:13 Changed 8 years ago by jmoore

Note: 3.6.9 is out and is end-of-line for 3.x (http://in.relation.to/Bloggers/HibernateCore40IsFinal)

comment:14 Changed 8 years ago by jburel

  • Sprint changed from 2012-01-03 (5) to 2012-01-17 (6)

Moved from sprint 2012-01-03 (5)

comment:15 Changed 8 years ago by jmoore

  • Sprint changed from 2012-01-17 (6) to 2012-01-31 (7)

Pushing to sprint7 since sprint6 is for bugs (also waiting on 3.6 v. 4.0 decision)

comment:16 Changed 8 years ago by jmoore

  • Sprint changed from 2012-01-31 (7) to 2012-02-14 (8)

Moved from sprint 2012-01-31 (7)

comment:17 Changed 8 years ago by jburel

  • Sprint changed from 2012-02-14 (8) to 2012-02-28 (9)

Moved from sprint 2012-02-14 (8)

comment:18 Changed 8 years ago by jmoore

  • Owner jmoore deleted
  • Status changed from accepted to new

comment:19 Changed 8 years ago by jburel

  • Sprint changed from 2012-02-28 (9) to 2012-03-13 (10)

Moved from sprint 2012-02-28 (9)

comment:20 Changed 8 years ago by jburel

  • Sprint changed from 2012-03-13 (10) to 2012-03-27 (11)

Moved from sprint 2012-03-13 (10)

comment:21 Changed 8 years ago by jburel

  • Sprint changed from 2012-03-27 (11) to 2012-04-10 (12)

Moved from sprint 2012-03-27 (11)

comment:22 Changed 8 years ago by jburel

  • Sprint changed from 2012-04-10 (12) to 2012-04-24 (13)

Moved from sprint 2012-04-10 (12)

comment:23 Changed 8 years ago by jburel

  • Sprint changed from 2012-04-24 (13) to 2012-05-08 (14)

Moved from sprint 2012-04-24 (13)

comment:24 Changed 8 years ago by jburel

  • Sprint changed from 2012-05-08 (14) to 2012-05-22 (15)

Moved from sprint 2012-05-08 (14)

comment:25 Changed 8 years ago by jburel

  • Sprint changed from 2012-05-22 (15) to 2012-06-05 (16)

Moved from sprint 2012-05-22 (15)

comment:26 Changed 7 years ago by jmoore

  • Milestone changed from OMERO-Beta4.4 to OMERO-Beta4.4.1
  • Sprint 2012-06-05 (16) deleted

Sorry, didn't realize this was being pushed from sprint to sprint. At this point (post freeze) I don't see us changing Hibernate unless absolutely necessary. Pushing to 4.4.1 for review.

comment:27 Changed 5 years ago by jamoore

  • Owner set to jballanco-x
  • Version set to 5.0.5

In discussion with Jason, we'll likely try to hold off on the Hibernate migration until post-5.1.0 in order to keep the Feb. 1 deadline. Leaving this in 5.x for the moment.

comment:28 Changed 5 years ago by jamoore

Initial bump to:

  • Hibernate 3.6.10 / Search 3.3.0 (3.4.2 is also an option)
  • Lucene 3.0.3
  • Spring 3.1.4 / LDAP 1.3.2 / Security 3.0.8
  • PostgreSQL 9.3-1102-jdbc4

is in: https://github.com/openmicroscopy/openmicroscopy/pull/3181

comment:29 Changed 4 years ago by jamoore

  • Milestone changed from 5.x to Unscheduled
Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.89791 sec.)

We're Hiring!