Upgrade Hibernate

[jamoore]

While preparing 4.2 (#1260), Hibernate released several patch versions.
And now after 4.3.3 Hibernate is at either:

• 3.6.8: ​http://in.relation.to/Bloggers/HibernateCore368FinalRelease
• or 4.0: ​http://in.relation.to/Bloggers/WhatsNewInHibernateCore40

See: ​http://in.relation.to/16459.lace

[jmoore]

Referencing ticket #1260 has changed sprint.

[jmoore]

Note: if we move to 4.0, then we could look at using multiple-tenancy as an improvement over our group-permissions. ​http://community.jboss.org/wiki/Multi-tenancyDesign

[jmoore]

Moved from sprint 2011-11-29 (3)

[jmoore]

Note: 4.0 is still in CR (candidate for release) and is _quite_ the change. Although if 4.4 is very long-term, it might ultimately be to our advantage to be on hib4, but it could also put us somewhat farther behind. On the other hand hib3.6 is up to 3.6.8 and I'd imagine quite stable (comparatively). I have a patch that applies it; no code changes were needed, but I still need to do some preliminary testing.

[jmoore]

Just ran into this:

Caused by: org.springframework.beans.BeanInstantiationException: Could not instantiate bean class [ome.tools.hibernate.SecurityFilter]: Constructor threw exception; nested exception is java.lang.NoSuchMethodError: org.hibernate.type.TypeFactory.heuristicType(Ljava/lang/String;)Lorg/hibernate/type/Type;
        at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:141)
        at org.springframework.beans.factory.support.SimpleInstantiationStrategy.instantiate(SimpleInstantiationStrategy.java:107)
        at org.springframework.beans.factory.support.ConstructorResolver.autowireConstructor(ConstructorResolver.java:273)
        ... 46 more
Caused by: java.lang.NoSuchMethodError: org.hibernate.type.TypeFactory.heuristicType(Ljava/lang/String;)Lorg/hibernate/type/Type;
        at org.springframework.orm.hibernate3.FilterDefinitionFactoryBean.setParameterTypes(FilterDefinitionFactoryBean.java:92)
        at ome.tools.hibernate.SecurityFilter.<init>(SecurityFilter.java:105)
        at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)

See: ​http://forum.springsource.org/showthread.php?117701-Migrating-to-Spring-3-0-3-with-Hibernate-3-6-5

[jmoore]

Fixed by upgrading to Spring 3.0.6.

Next issue: SoftLimitMRUCache

See: ​http://comments.gmane.org/gmane.comp.java.cdi.seam.issues/712

[jmoore]

That was fixed by upgrading Hibernate search to 3.4.1 which brought along Lucene 3.1.0 which changed the ctor of QueryParser:

See: ​https://issues.apache.org/jira/browse/LUCENE-2002

[jmoore]

Unexpected results during testing:

Bad query: Illegal query:select i from Image i where i.pixels.id = 352
illegal attempt to dereference collection [image0_.id.pixels] with element property reference [id] [select i from ome.model.core.Image i where i.pixels.id = 352]

On the other hand, the Java tests looked quite ok:

  [testng] ===============================================
  [testng] OmeroJava.integration
  [testng] Total tests run: 410, Failures: 2, Skips: 0
  [testng] ===============================================

and one of those is:

[testng] FAILED: testDowngradeTo201006ImageNoMetadata on instance null(integration.schema.Schema2011_06_TO_2010_06_Test)
  [testng] java.io.FileNotFoundException: /Users/andrew/Desktop/wibble1.xml (No such file or directory)

Search is likely quite broken since the indexer needs modification.

[jburel]

The last test failure also happened in feature/reorganise_jar_new.

[jburel]

Moved from sprint 2011-12-13 (4)

[jmoore]

Note: 3.6.9 is out and is end-of-line for 3.x (​http://in.relation.to/Bloggers/HibernateCore40IsFinal)

[jburel]

Moved from sprint 2012-01-03 (5)

[jmoore]

Pushing to sprint7 since sprint6 is for bugs (also waiting on 3.6 v. 4.0 decision)

[jmoore]

Moved from sprint 2012-01-31 (7)

[jburel]

Moved from sprint 2012-02-14 (8)

[jburel]

Moved from sprint 2012-02-28 (9)

[jburel]

Moved from sprint 2012-03-13 (10)

[jburel]

Moved from sprint 2012-03-27 (11)

[jburel]

Moved from sprint 2012-04-10 (12)

[jburel]

Moved from sprint 2012-04-24 (13)

[jburel]

Moved from sprint 2012-05-08 (14)

[jburel]

Moved from sprint 2012-05-22 (15)

[jmoore]

Sorry, didn't realize this was being pushed from sprint to sprint. At this point (post freeze) I don't see us changing Hibernate unless absolutely necessary. Pushing to 4.4.1 for review.

[jamoore]

In discussion with Jason, we'll likely try to hold off on the Hibernate migration until post-5.1.0 in order to keep the Feb. 1 deadline. Leaving this in 5.x for the moment.

[jamoore]

Initial bump to:

• Hibernate 3.6.10 / Search 3.3.0 (3.4.2 is also an option)
• Lucene 3.0.3
• Spring 3.1.4 / LDAP 1.3.2 / Security 3.0.8
• PostgreSQL 9.3-1102-jdbc4

is in: ​https://github.com/openmicroscopy/openmicroscopy/pull/3181