Task #2574 (closed)
Opened 9 years ago
Closed 8 years ago
Make "name" fields optional in SPW
| Reported by: | jamoore | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-Beta4.3 |
| Component: | ORM | Version: | n.a. |
| Keywords: | n.a. | Cc: | jburel, cxallan, ajpatterson, jrswedlow |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2011-04-21 (10) |
Description (last modified by jburel)
Devteam 2010-07-08:
chris:
Might have a database issue on PlateAcqusition that needs a fix, one sec.
chris 10:07
<xsd:element name="PlateAcquisition"> <!-- top level definition -->
07:40
...
07:48
<xsd:attribute name="Name" use="optional" type="xsd:string"/>
...
08:02
name | character varying(255) | not null
08:50
Ditto for reagent.
09:02
name | character varying(255) | not null
09:35
Is this one of these "inherits from 'named'" issues?
josh moore 10:09
yeah.
chris 10:09
Same for Plate too.
josh moore 10:10
so it's actually not that bad.
10:23
which name's need to be non-nullable on SPW?
chris 10:10
The Plate ID and Name attributes are required.
...
10:25
Heh.
josh moore 10:10
um, right.
chris 10:10
<xsd:attribute name="Name" use="optional" type="xsd:string">
josh moore 10:10
you guys decide that and let me know.
chris 10:11
All the attributes are optional.
josh moore 10:11
screen as well?
chris 10:11
In the schema, yes.
josh moore 10:12
seems a bit counter to PDI but whatever. ok. all "named=true" are being removed from screen.ome.xml, and replaced with <optional name="name" type="string"/>.
chris 10:12
I'll probably work around that one though by using the ID if the name doesn't exist.
josh moore 10:12
for mage, i'll just fix it by hand.
chris 10:12
Having a Screen with no name is going to muck up a ton of stuff.
josh moore 10:13
i'd bet jean-marie is expecting a plate.name as well. he usually has code in place to do null ? "" : name, but still.
chris 10:13
I just hope that J-M isn't relying on these other names being there, might be a bad idea to change this now.
13:44
During Import I might just insert the object ID if that Name is null.
chris 10:18
Working around it in code for now Josh.
josh moore 10:28
ok. so we're not changing the DB. i'll add a ticket for 4.2.1
Decision
- Name should not be optional for Project, Dataset, Image, Screen, Plate. The only exception being PlateAcquisition
- Model: update model.
Change History (5)
comment:1 Changed 9 years ago by cxallan
comment:2 Changed 8 years ago by jburel
- Description modified (diff)
- Milestone changed from Unscheduled to OMERO-Beta4.3
comment:3 Changed 8 years ago by jmoore
Referencing ticket #2568 has changed sprint.
comment:4 Changed 8 years ago by jmoore
- Sprint set to 2011-04-21 (10)
comment:5 Changed 8 years ago by jmoore <josh@…>
- Remaining Time set to 0
- Resolution set to fixed
- Status changed from new to closed
(In [c5bf2dfcf8a44a4c1d1b3fc421eec2c35cbcbdc9/ome.git] on branch develop) Some SPW name fields optional (Fix #2574)
Note: See
TracTickets for help on using
tickets.
You may also have a look at Agilo extensions to the ticket.
(In [7495]) Various fixes for OME-XML files of SPW type: