Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #2596 (closed)

Opened 14 years ago

Closed 8 years ago

Last modified 8 years ago

Clear or filter all findbugs-found issues

Reported by: jamoore Owned by:
Priority: major Milestone: Unscheduled
Component: General Version: OMERO-5.2.0
Keywords: n.a. Cc: jburel
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description (last modified by jmoore)

For the 4.2.0 release, a NPE was found by findbugs but we didn't fix until it arose in the field because there were too many open findbugs issues.

See: ​http://hudson.openmicroscopy.org.uk/job/OMERO-trunk-findbugs/2442/findbugsResult/HIGH/?

Change History (26)

comment:1 Changed 14 years ago by ajpatterson

(In [7685]) Fixing broken reference to logger, now log #2596

comment:2 Changed 14 years ago by ajpatterson

(In [7682]) Should now suppress the unused log fields correctly, also renamed a few variables from logger to log so they are caught be the same rule. #2596

comment:3 Changed 14 years ago by ajpatterson

(In [7679]) Another try at adding a filter to stop findbugs reporting an unused field called 'log' in a class. #2596

comment:4 Changed 14 years ago by ajpatterson

(In [7677]) Adding a filter to stop findbugs reporting an unused field called 'log' in a class. #2596

comment:5 Changed 14 years ago by ajpatterson

The last four messages were added manually and are in reverse order.

comment:6 Changed 14 years ago by bwzloranger

(In [7686]) Fixes for findbugs errors (See #2596).

comment:7 Changed 14 years ago by jmoore

(In [7760]) Removing unused ome.services.util.cache (See #2596)

comment:8 Changed 13 years ago by cxallan

Referencing ticket #1736 has changed sprint.

comment:9 Changed 12 years ago by jmoore

  • Description modified (diff)
  • Milestone changed from Unscheduled to OMERO-Beta4.4
  • Sprint set to 2012-01-17 (6)

Moving to sprint 6 (the bug sprint) for possible handling.

comment:10 Changed 12 years ago by jburel

  • Sprint changed from 2012-01-17 (6) to 2012-01-31 (7)

Moved from sprint 2012-01-17 (6)

comment:11 Changed 12 years ago by jmoore

  • Sprint changed from 2012-01-31 (7) to 2012-02-14 (8)

Moved from sprint 2012-01-31 (7)

comment:12 Changed 12 years ago by jburel

  • Sprint changed from 2012-02-14 (8) to 2012-02-28 (9)

Moved from sprint 2012-02-14 (8)

comment:13 Changed 12 years ago by jburel

  • Sprint changed from 2012-02-28 (9) to 2012-03-13 (10)

Moved from sprint 2012-02-28 (9)

comment:14 Changed 12 years ago by jburel

  • Sprint changed from 2012-03-13 (10) to 2012-03-27 (11)

Moved from sprint 2012-03-13 (10)

comment:15 Changed 12 years ago by jburel

  • Sprint changed from 2012-03-27 (11) to 2012-04-10 (12)

Moved from sprint 2012-03-27 (11)

comment:16 Changed 12 years ago by jburel

  • Sprint changed from 2012-04-10 (12) to 2012-04-24 (13)

Moved from sprint 2012-04-10 (12)

comment:17 Changed 12 years ago by jburel

  • Sprint changed from 2012-04-24 (13) to 2012-05-08 (14)

Moved from sprint 2012-04-24 (13)

comment:18 Changed 12 years ago by jburel

  • Sprint changed from 2012-05-08 (14) to 2012-05-22 (15)

Moved from sprint 2012-05-08 (14)

comment:19 Changed 12 years ago by jburel

  • Sprint changed from 2012-05-22 (15) to 2012-06-05 (16)

Moved from sprint 2012-05-22 (15)

comment:20 Changed 12 years ago by jburel

  • Sprint changed from 2012-06-05 (16) to 2012-06-19 (17)

Moved from sprint 2012-06-05 (16)

comment:21 Changed 12 years ago by jmoore

  • Milestone changed from OMERO-Beta4.4 to OMERO-Beta4.4.1
  • Sprint 2012-06-19 (17) deleted

Won't have time for 4.4.0. Perhaps something for over the summer (4.4.1)

comment:22 Changed 12 years ago by jmoore

Referencing ticket #1736 has changed sprint.

comment:23 Changed 8 years ago by jamoore

  • Milestone changed from 5.x to Unscheduled

comment:24 Changed 8 years ago by jburel

  • Resolution set to invalid
  • Status changed from new to closed
  • Version set to OMERO-5.2.0

No point to keep that ticket around. Our CI infrastructure has evolved since the opening of the ticket.

comment:25 Changed 8 years ago by jamoore

Not that we need this ticket, but note that findbugs is not run on OMERO by Jenkins:

[jamoore@ome-ci-master ws]$ git grep -l FindBugsPublisher
jobs/BIOFORMATS-4.4-merge-daily/config.xml
jobs/BIOFORMATS-5.0-merge-build/config.xml
jobs/BIOFORMATS-5.1-merge-build-win/config.xml
jobs/BIOFORMATS-5.1-merge-build/config.xml
jobs/BIOFORMATS-DEV-breaking-build/config.xml
jobs/BIOFORMATS-DEV-merge-build-win/config.xml

I'll look at activating it in travis.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.69440 sec.)

© 2000-2014 University of Dundee & Open Microscopy Environment. Creative Commons Attribution 3.0 Unported License
OME source code is available under the GNU General public license or through commercial license from Glencoe Software

We're Hiring!