Delete Refactoring and Performance improvements

[jamoore]

The current implementation of IDelete leaves much to be desired:

• Not enough methods to transactionally handle all deletes
• Too many objects are loaded into memory
• Too few EventLogs are created for some deletes

Scenarios

description of possible workflow

• Select an image to delete.
  • Annotations like Comments, rating should be deleted at the same time.
  • Rois if any should be deleted.
  • Ask user if wants to delete annotations that can be shared e.g. tag, ontology, document
  • Settings, acquisition data should be deleted too (since we don't share them)
• Select a dataset to delete.
  • Need to option to delete contents (similar to Eclipse) i.e. delete images
  • Same options as before. If Tag, documents have to be deleted, then the same strategy will be applied for images.

[jmoore]

Notes from discussion (Jean-Marie, Josh, Chris):

• Intro
  • Josh: looked at gateway, there seem
  • Josh: there was also something about changing the workflow.
  • Jean-Marie: no, misunderstanding. Need to better handle the feedback. (long time)
  • Josh: need to figure out how much feedback if something wasn't deleted, e.g.
  • Chris: how much deleting is happening in Insight?
  • Quite a bit is done via IUpdate.deleteObject

• General behavior
  • Delete everything possible, or unlink if its linked more than once
  • Need to immediately free disk-space
  • Chris: How to specify the configuration?
    • Jean-Marie: only option is for "tags"
    • only need for certain kinds of comments. (tag, attachments)
    • Chris: Linked once it goes? Jean-Marie: that could be disturbing.
      • e.g. ontology term and/or attached file might have own value
  • Orphans (report of things that need to be cleaned up)
    • Binary data and Tags / attachments
    • Another window like Activity window
  • Group deletes
    • Datasets need the same functionality, so even images go
    • Image, Dataset, Project, Plate, Screen
    • bool of whether or not to delete me if I'm an orphan
  • May not need to handle something like CommentAnnotation specially
  • Things that are typically not shared (rating, comments, ...) should just be wiped out

• Steps
  • Making a list of graphs that we want to delete (users' expectations?)
  • Encoding those in python to test against objects
  • ...

• ...Coffee...

• API
  • Project, Dataset, Image, Plate, Screen, ROI
  • DeleteHandle deleteObject(Class klass, List<Long> ids, DeleteParams parameters);
  • List<Boolean> isInDeleteQueue(Class klass, List<Long> ids);
  • AlreadyDeletedException

• State
  • Getting a report of a on delete
  • Getting a notification of delete/failure/(de-)queueing
  • Managing expectations