Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

User Story #2631 (closed)

Opened 14 years ago

Closed 9 years ago

Refactor and simplify preferences in importer

Reported by: jamoore Owned by:
Priority: major Milestone: Unscheduled
Component: Import Keywords: n.a.
Cc: bwzloranger Story Points: n.a.
Sprint: n.a. Importance: n.a.
Total Remaining Time: n.a. Estimated Remaining Time: n.a.

Description

The classes providing preferences in the importer need to be significantly refactored. There is a mixture of library-configuration, cli-configuration, and gui-configuration. Each of the classes needs to have clear responsibilities.

For example, in #2325 support was added for "archiveImage" but only to the GUI.

I'd suggest that ALL configuration properties go into ImportConfig as fields (not methods). Then for each type of application -- e.g. cli, gui -- the proper fields can be loaded on startup and saved on shutdown.

IniFileLoader should most likely be the one-stop-shop for saving preferences, all of which under ~/omero/import.ini, rather than using any OS-based location (e.g. ~/.MacOSX or ~/.java)

See also #1263

Change History (5)

comment:1 Changed 14 years ago by jmoore

(In [7607]) Refactoring 'archiveImage' functionality in ImportLibrary (Fix #1263, #2623, See #2325, #2631)

comment:2 Changed 14 years ago by jmoore

(In [7608]) Removing temporary file creation. (See #2631)

comment:3 Changed 14 years ago by jmoore

(In [7610]) Refactoring 'archiveImage' functionality in ImportLibrary (Fix #1263, #2623, See #2325, #2631)

original-svn-id: file:///home/svn/omero/branches/Beta4.2@7607 05709c45-44f0-0310-885b-81a1db45b4a6

comment:4 Changed 14 years ago by jmoore

(In [7611]) Removing temporary file creation. (See #2631)

original-svn-id: file:///home/svn/omero/branches/Beta4.2@7608 05709c45-44f0-0310-885b-81a1db45b4a6

comment:5 Changed 9 years ago by jburel

  • Resolution set to invalid
  • Status changed from new to closed

No longer valid

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.64117 sec.)

We're Hiring!