Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #2873 (closed)

Opened 14 years ago

Closed 14 years ago

Web should be careful to not call changePermissions

Reported by: jamoore Owned by: atarkowska
Priority: minor Milestone: OMERO-Beta4.2.1
Component: Security Version: n.a.
Keywords: n.a. Cc:
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2010-09-09 (16)

Description

It might be that Web is calling changePermissions unintentionally. See 2010.09.14 notes.

Change History (3)

comment:1 Changed 14 years ago by jmoore

    public void updateGroup(@NotNull final
    ExperimenterGroup group) {
        adminOrPiOfGroup(group);
        Permissions p = group.getDetails().getPermissions();
        if (p != null) {
            // Setting permissions is not allowed via IUpdate
            // so use the logic in changePermissions and then
            // reset permissions to the current value.
            changePermissions(group, p); // ticket:1776 WORKAROUND
        }
        final ExperimenterGroup orig = getGroup(group.getId());
        orig.setName(group.getName());
        orig.setDescription(group.getDescription());

        reallySafeSave(orig);
        getBeanHelper().getLogger().info("Updated group info for " + group);
    }

Looks like it is necessary to null the permissions on the group object being passed back.

comment:2 Changed 14 years ago by atarkowska

  • Status changed from new to assigned

comment:3 Changed 14 years ago by atarkowska

  • Remaining Time set to 0
  • Resolution set to fixed
  • Status changed from assigned to closed

(In [8085]) this fixes #2895, #2802, #2873

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.66592 sec.)

We're Hiring!