Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Bug #291 (closed)

Opened 13 years ago

Closed 13 years ago

Equals and hashCode are missing for Permissions

Reported by: jamoore Owned by: jamoore
Priority: major Cc:
Sprint: n.a.
Total Remaining Time: n.a.

Description

equals and hashCode are implementable and in fact quite useful for the Permissions class.

Change History (4)

comment:1 Changed 13 years ago by jmoore

Because Permissions are mutable, this may cause problems (specifically certain instances getting lost in a Set.). Instead we can provide a non-overriding equality comparison ("identical",e.g.). This may should be rethought and rather than having an immutable wrapper around Permissions, we make Permissions immutable and provide a mutable builder (a la String and StringBuilder).

comment:2 Changed 13 years ago by jmoore

r882 adds this functionality with simple test. The code needed for equals/hashCode is present but commented out.

comment:3 Changed 13 years ago by jmoore

r918 adds sameRights(Permissions) as a less strict equality test.

comment:4 Changed 13 years ago by jmoore

  • Keywords set to iteration4
  • Resolution set to fixed
  • Status changed from new to closed

Closing this with the assumption that when someone needs true equals/hashCode functionality it'll be re-opened.

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.72223 sec.)

We're Hiring!