Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #2962 (closed)

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

Delete Tag as Root

Reported by: jburel Owned by: jamoore
Priority: critical Milestone: OMERO-Beta4.2.1
Component: General Version: n.a.
Keywords: n.a. Cc: wmoore
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2010-09-30 (17)

Description

scenario rwrw-- group:

  • user1 owns image1
  • user2 creates tag2
  • user1 tags image1 with tag2
  • user2 then tries to delete tag2


Error: security violation.
Tested added but not turned on

Change History (11)

comment:1 Changed 9 years ago by jmoore

  • Status changed from new to assigned

comment:2 Changed 9 years ago by jmoore

  • Remaining Time set to 0.25

comment:3 Changed 9 years ago by jmoore

In conversation with Jean-Marie and Will, the danger of deleting a tag (loss of image linkage information) was decided to be higher than the renaming of a tag (which is primarily confusing), and therefore, if user1 has used user2's tag, user2 can no longer delete those tags.

comment:4 Changed 9 years ago by jmoore

  • Remaining Time changed from 0.25 to 0
  • Resolution set to fixed
  • Status changed from assigned to closed

(In [8199]) Deciding to disallow deleting tags used by others (Fix #2962)

comment:5 Changed 9 years ago by jburel

  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening
insight#1651

comment:6 Changed 9 years ago by jburel

Added test.
In the current implementation, if user2 is group owner, user can delete the tag and the link.
Is it what we want?

comment:7 Changed 9 years ago by jburel

(In [8286]) Added test related to delete tag (see #2962)

comment:8 Changed 9 years ago by jburel

  • Cc wmoore added

comment:9 Changed 9 years ago by jmoore

(In [8297]) Enabling passing test (See #2962)

comment:10 Changed 9 years ago by jburel

  • Resolution set to fixed
  • Status changed from reopened to closed

Following today's decision, we can close it

comment:11 Changed 9 years ago by jmoore

(In [8300]) Fixing test (See #2962)

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.82925 sec.)

We're Hiring!