Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #2997 (closed)

Opened 11 years ago

Closed 6 years ago

Last modified 6 years ago

Delete other user's rating, comment

Reported by: wmoore Owned by: mtbcarroll
Priority: critical Milestone: 5.1.2
Component: General Version: 5.1.1
Keywords: n.a. Cc: server@…
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: n.a.

Description (last modified by wmoore)

If another user rates my image, then I delete the image, the rating should probably be deleted too IF it becomes an orphan? Currently only the imageannotationlink is removed from the db, but not the annotation itself.

The same case applies to another user's COMMENT on my Image. Delete the image and the comment is still in the db.

Change History (18)

comment:1 Changed 11 years ago by jmoore

  • Status changed from new to assigned

comment:2 Changed 11 years ago by jmoore

(In [8231]) Passing delete tests for protocol (See #2994) and failing ones for ratings (See #2997)

comment:3 Changed 11 years ago by jmoore

  • Milestone changed from OMERO-Beta4.2.1 to Unscheduled
  • Owner jmoore deleted
  • Sprint 2010-09-30 (17) deleted
  • Status changed from assigned to new

Moving to phase 2. See #2999 (delete dangling objects) which should solve any issues with this during 4.2.1.

comment:4 Changed 11 years ago by wmoore

  • Description modified (diff)
  • Summary changed from Delete other user's rating to Delete other user's rating, comment

comment:5 Changed 10 years ago by jmoore

Referencing ticket #4329 has changed sprint.

comment:6 Changed 10 years ago by wmoore

  • Milestone changed from Unscheduled to OMERO-Beta4.3.2
  • Owner set to jmoore

http://trac.openmicroscopy.org.uk/ome/changeset/8231/omero

Other users' comments and ratings are not deleted when an image is deleted (just tested manually).
Haven't tried running those tests (not sure if the Java tests are turned on or off just now (or which test this ticket refers to).

comment:7 Changed 10 years ago by jburel

Referencing ticket #4329 has changed sprint.

comment:8 follow-up: Changed 10 years ago by jmoore

Will, the task to fix this was pushed to (#2999) "Unscheduled". Was there some discussion to prioritize this for 4.3.2?

comment:9 in reply to: ↑ 8 Changed 10 years ago by wmoore

Replying to jmoore:

Will, the task to fix this was pushed to (#2999) "Unscheduled". Was there some discussion to prioritize this for 4.3.2?

It's not been prioritized so far. I guess it's something we should do at some point for "tidyness" rather than anything else. But not really a priority. Depends on how hard it is and how busy you are I guess?

comment:10 Changed 10 years ago by jmoore

  • Cc saloynton added
  • Milestone changed from OMERO-Beta4.3.2 to Unscheduled
  • Priority changed from minor to major

Pushing back to Unscheduled (see above)

comment:11 Changed 10 years ago by saloynton

Referencing ticket #4634 has changed sprint.

comment:12 Changed 10 years ago by jburel

Referencing ticket #4329 has changed sprint.

comment:13 Changed 9 years ago by jburel

Referencing ticket #8100 has changed sprint.

comment:14 Changed 9 years ago by jmoore

  • Milestone changed from Unscheduled to OMERO-Beta4.4.x
  • Priority changed from major to critical

comment:15 Changed 6 years ago by mtbcarroll

  • Cc server@… added; saloynton removed
  • Milestone changed from 5.x to 5.1.2
  • Owner changed from jamoore to mtbcarroll

comment:16 Changed 6 years ago by mtbcarroll

  • Status changed from new to accepted
  • Version set to 5.1.1

comment:17 Changed 6 years ago by mtbcarroll

  • Resolution set to fixed
  • Status changed from accepted to closed

comment:18 Changed 6 years ago by Josh Moore <josh@…>

  • Remaining Time set to 0

(In [4d6509980f5cc523a19787d3ed7547694dcd8316/ome.git] on branch develop) Merge pull request #3778 from mtbc/trac-2997-annotation-deletion

fix #2997: delete non-sharable annotations with image

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.113284 sec.)

We're Hiring!