Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #2999 (closed)

Opened 14 years ago

Closed 8 years ago

Remove all unlinked non-shareable annotations

Reported by: jamoore Owned by:
Priority: major Milestone: B-F-5.2.0
Component: Deployment Version: 5.1.1
Keywords: n.a. Cc: ux@…
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: n.a.
Sprint: n.a.

Description

As a carry over from the delete rework (#2615), some objects may have been left dangling (#2932). These should be removed on the next database upgrade.

Change History (30)

comment:1 Changed 13 years ago by jmoore

Referencing ticket #2568 has changed sprint.

comment:2 Changed 13 years ago by jmoore

Referencing ticket #4891 has changed sprint.

comment:3 Changed 9 years ago by mtbcarroll

  • Milestone changed from Unscheduled to 5.2.0-m1
  • Owner set to mtbcarroll
  • Version set to 5.1.1

comment:4 Changed 9 years ago by mtbcarroll

Which annotations to delete may be informed by the outcome of https://trello.com/c/T3UX9YZe.

comment:5 Changed 9 years ago by mtbcarroll

Note that integration tests like AnnotationMoveTest.testMoveImageAnnotatedByUsersOneNotInDestinationGroupDestinationGroupRWRAtoRWRA seem to positively require that non-sharable annotations are left dangling.

comment:6 Changed 9 years ago by mtbcarroll

If unlinking a non-sharable annotation via Delete2 can automatically delete it (e.g., a rating) then OMERO.web has trouble deleting some annotations -- see https://github.com/openmicroscopy/openmicroscopy/blob/8cf95413/components/blitz/resources/ome/services/graph-rules/blitz-delete-rules.xml#L191 -- perhaps that needs fixing first or more objects may become dangled.

comment:7 Changed 9 years ago by jamoore

Is 5.2 still appropriate here?

comment:8 Changed 9 years ago by mtbcarroll

Yes if changes to OMERO.web and integration tests are also made for 5.2.

comment:9 Changed 9 years ago by jamoore

  • Milestone changed from 5.2.0 to OMERO-5.2.0

Splitting due to milestone decoupling.

comment:10 Changed 9 years ago by mtbcarroll

  • Cc ux@… added; jburel removed

comment:11 Changed 9 years ago by mtbcarroll

Note from comments above that if this is to be done in any useful way for 5.2.0 then web changes and integration test changes are probably needed.

comment:12 Changed 8 years ago by mtbcarroll

So, need confirmation that it's okay to change https://trac.openmicroscopy.org/ome/ticket/2999#comment:5. Also, I could make the change in the server, and then web people can deal with https://trac.openmicroscopy.org/ome/ticket/2999#comment:6?

comment:13 Changed 8 years ago by wmoore

Mark, once this ticket is done, if web needs to subsequently change, just let me know what to fix and re-assign ticket to me - Thanks.

comment:14 Changed 8 years ago by mtbcarroll

Thank you! Just realized that even this web change would probably be technically breaking, so will do this once we branch dev_5_2.

comment:15 Changed 8 years ago by jburel

  • Milestone changed from OMERO-5.2.1 to OMERO-5.2.2

Milestone OMERO-5.2.1 deleted

comment:16 Changed 8 years ago by jburel

  • Milestone changed from OMERO-5.2.2 to OMERO-5.2.1

Milestone OMERO-5.2.2 deleted

comment:17 Changed 8 years ago by mtbcarroll

Unlinked non-shareable annotations can be counted by,

SELECT discriminator, COUNT(*) FROM annotation WHERE discriminator IN ('/basic/bool/', '/basic/num/double/', '/basic/num/long/', '/basic/term/', '/basic/time/', '/basic/text/comment/') AND id NOT IN (SELECT child FROM annotationannotationlink) AND id NOT IN (SELECT child FROM channelannotationlink) AND id NOT IN (SELECT child FROM datasetannotationlink) AND id NOT IN (SELECT child FROM detectorannotationlink) AND id NOT IN (SELECT child FROM dichroicannotationlink) AND id NOT IN (SELECT child FROM experimenterannotationlink) AND id NOT IN (SELECT child FROM experimentergroupannotationlink) AND id NOT IN (SELECT child FROM filesetannotationlink) AND id NOT IN (SELECT child FROM filterannotationlink) AND id NOT IN (SELECT child FROM imageannotationlink) AND id NOT IN (SELECT child FROM instrumentannotationlink) AND id NOT IN (SELECT child FROM lightpathannotationlink) AND id NOT IN (SELECT child FROM lightsourceannotationlink) AND id NOT IN (SELECT child FROM namespaceannotationlink) AND id NOT IN (SELECT child FROM nodeannotationlink) AND id NOT IN (SELECT child FROM objectiveannotationlink) AND id NOT IN (SELECT child FROM originalfileannotationlink) AND id NOT IN (SELECT child FROM planeinfoannotationlink) AND id NOT IN (SELECT child FROM plateacquisitionannotationlink) AND id NOT IN (SELECT child FROM plateannotationlink) AND id NOT IN (SELECT child FROM projectannotationlink) AND id NOT IN (SELECT child FROM reagentannotationlink) AND id NOT IN (SELECT child FROM roiannotationlink) AND id NOT IN (SELECT child FROM screenannotationlink) AND id NOT IN (SELECT child FROM sessionannotationlink) AND id NOT IN (SELECT child FROM shapeannotationlink) AND id NOT IN (SELECT child FROM wellannotationlink) GROUP BY discriminator;

comment:18 Changed 8 years ago by mtbcarroll

jamoore is going to check some production databases next week to judge the character and prevalence of such unlinked non-shareable annotations. The result of that determines the next steps.

comment:19 Changed 8 years ago by jamoore

Referencing ticket #9165 has changed sprint.

comment:20 Changed 8 years ago by jamoore

Referencing ticket #9165 has changed sprint.

comment:21 Changed 8 years ago by jburel

  • Milestone changed from OMERO-5.2.2 to GatherReqs

comment:22 Changed 8 years ago by mtbcarroll

I tried deleting a comment and saw separate delete calls for ImageAnnotationLink, CommentAnnotation (dry run), CommentAnnotation. With rating I just got ImageAnnotationLink then LongAnnotation. The rules adjustment should make it such that deletion of the ImageAnnotationLink alone suffices.

comment:23 Changed 8 years ago by mtbcarroll

Opened https://github.com/openmicroscopy/openmicroscopy/pull/4585 to try to prevent further unlinked non-shareable annotations from being unintentionally created.

comment:24 Changed 8 years ago by mtbcarroll

  • Resolution set to fixed
  • Status changed from new to closed

comment:25 Changed 8 years ago by jamoore

  • Milestone changed from GatherReqs to B-F-5.2.0
  • Resolution fixed deleted
  • Status changed from closed to reopened

I'd assume something should at least look at that for testing.

comment:26 Changed 8 years ago by jamoore

  • Owner mtbcarroll deleted
  • Status changed from reopened to accepted

comment:28 Changed 8 years ago by sbesson

I don't think this belongs to the BF-5.2.0 milestone. Do we have a placeholder to come back to this as part of the OMERO 5.3.0 testing Jean-Marie?

comment:29 Changed 8 years ago by mtbcarroll

comment:30 Changed 8 years ago by sbesson

  • Resolution set to fixed
  • Status changed from accepted to closed

Closing in favor of a checklist item on the OMERO 5.3.0 QA card

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.116245 sec.)

We're Hiring!