Task #312 (closed)
Opened 18 years ago
Closed 18 years ago
Unify checks of SecurityFilter and BasicSecuritySystem
Reported by: | jamoore | Owned by: | jamoore |
---|---|---|---|
Priority: | trivial | Milestone: | 3.0-M3 |
Component: | Security | Version: | 3.0-M3 |
Keywords: | refactor,iteration5 | Cc: | |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description (last modified by jmoore)
SecuritySystem.allowLoad delegates to SecurityFilter.passesFilter which has someone copied code regarding nulled values. passesFilter should take long values and a non-null Permissions for its check, and the rest of the logic should sit in BasicSecuritySystem.
Change History (2)
comment:1 Changed 18 years ago by jmoore
- Keywords iteration5 added
comment:2 Changed 18 years ago by jmoore
- Description modified (diff)
- Resolution set to fixed
- Status changed from new to closed
Cleaned up (r952). Now only the nullness of Details and Permissions could be extracted, but that's not necessarily cleaner. Closing.
Rescheduling with #328