Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #3131 (closed)

Opened 14 years ago

Closed 13 years ago

Bug: sessions contain loaded events after saving

Reported by: jamoore Owned by:
Priority: critical Milestone: OMERO-Beta4.3
Component: Performance Version: n.a.
Keywords: n.a. Cc: jburel, cxallan
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2011-02-24 (6)

Description (last modified by jmoore)

There's no reason that the events should be returned, and for a very long running session this list could become quite large, eating up both bandwidth and memory.

...

In [33]: la.ns = ns

In [34]: la = client.sf.getUpdateService().saveAndReturnObject(la)

In [35]: la.ns = ns2

In [36]: la = client.sf.getUpdateService().saveAndReturnObject(la)

In [37]: la.ns = ns

In [38]: la = client.sf.getUpdateService().saveAndReturnObject(la)

In [39]: search.byFullText(la.ns.val)

In [40]: search.hasNext()
Out[40]: True

In [41]: search.res
search.resetDefaults        search.resetDefaults_async  search.results              search.results_async        

In [41]: len(search.results())
Out[41]: 1

In [42]: len(la.details.updateEvent.session.copyEvents())
Out[42]: 5

In [43]: len(la.details.updateEvent.session.copyEvents())
Out[43]: 5

Change History (5)

comment:1 Changed 14 years ago by jmoore

  • Description modified (diff)
  • Owner set to jmoore
  • Remaining Time set to 0.25
  • Status changed from new to assigned

comment:2 Changed 14 years ago by jmoore

  • Description modified (diff)
  • Milestone OMERO-Beta4.2.1 deleted
  • Priority changed from major to critical
  • Sprint 2010-10-28 (18) deleted

It's not clear just where the best place to do this filtering is, or the consequences (where are the events used). I.e. it might be dangerous to change this behavior in the point release. Pushing.

comment:3 Changed 13 years ago by jmoore

  • Milestone set to OMERO-Beta4.3
  • Sprint set to 2011-02-24 (6)

Several fixes from iteration (5) may have made this go away. Should review.

comment:4 Changed 13 years ago by jmoore

  • Owner jmoore deleted
  • Status changed from assigned to new

comment:5 Changed 13 years ago by jmoore <josh@…>

  • Remaining Time changed from 0.25 to 0
  • Resolution set to fixed
  • Status changed from new to closed

(In [dd77e8ddfbb36799b3a81fa76f9388d087af2376/ome.git] on branch develop) Passing tests; can't reproduce leaking session.events (Closes #3131)

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.67107 sec.)

We're Hiring!