Possibly omit original_metadata.txt if it's empty

[jamoore]

In the case of png imports, the original_metadata.txt consists of this:

[GlobalMetadata]
[SeriesMetadata]

which could almost certainly be omitted.

[jmoore]

Is this something that should be evaluated along with the fs work?

[cxallan]

Yes.

[jamoore]

Moving this into beta2. Likely we should just close it, since we are no longer generating these files. The only thing that occurs to me is that we could look for original_metadata.txt files which equal exactly this value and delete them. Thoughts?

[jburel]

Agree, we should delete them,
we now also handle file of size=0

[cblackburn]

Delete the zero-sized files as part of the import process? Or delete them as a periodic clean-up?

[jburel]

I will delete during the import process. No real need to create and keep a zero-size file

[cblackburn]

Is this something that is in Insight's control or does it also need to be done by other import clients? Or does it need to be done server-side. If it is only an Insight issue do you want to take this ticket?

[jburel]

In my view, this is not an insight specific issue but an import sequence issue.
We could argue that the deletion of the file could be part of a "clean-up" phase if an error occurred e.g. the image object is created even if failure
That could be done later.

[cblackburn]

original_metadata.txt files are no longer created during import. Any zero-sized or minimal files that exist because of an upgrade from 4.4 to 5.0 should be handled by an improved cleanse.py script. See ​https://trac.openmicroscopy.org.uk/ome/ticket/11791