Bug: bin/omero admin methods possibly broken on Windows

[jamoore]

Many of the functions under bin/omero admin assume access to the OMERO_HOME and omero.data.dir directories as the user running the server. On Windows, this assumption is broken when using the default icegridnode install.

See #3513

[jmoore]

(In [8672]) Exiting from can_access if on Windows (Fix #3513, See #3596)

[jmoore]

(In [8673]) Exiting from can_access if on Windows (See #3513, #3596)

original-svn-id: ​file:///home/svn/omero/trunk@8672 05709c45-44f0-0310-885b-81a1db45b4a6

[jmoore]

This should probably be reviewed under the category of "bug". Worst case: the commands should be disabled on Windows.

[jmoore]

Users should just see an exception on the console when using these, so pushing.

[jmoore]

Safe Windows methods

    start             Start icegridnode daemon and waits for required components to come up, i.e. status == 0
    startasync        The same as start but returns immediately.
    restart           stop && start
    restartasync      The same as restart but returns as soon as starting has begun.
    status            Status of server.
    stop              Initiates node shutdown and waits for status to return a non-0 value
    stopasync         The same as stop but returns immediately.
    deploy            Deploy the given deployment descriptor. See etc/grid/*.xml
    ice               Drop user into icegridadmin console or execute arguments
    diagnostics       Run a set of checks on the current, preferably active server
    waitup            Used by start after calling startasync to wait on status==0
    waitdown          Used by stop after calling stopasync to wait on status!=0
    checkwindows      Run simple check of the local installation (Windows-only)
    ports             Allows modifying the ports from a standard OMERO install
    sessionlist       List currently running sessions
    events            Print event log (Windows-only)

• The start/stop methods are all now safe due to other commits on this ticket which skip the can_access method under Windows.

Possibly unusable methods

    reindex           Re-index the Lucene index
    cleanse           Remove binary data files from OMERO.

• reindex and cleanse may fail if the current user does not have permissions for the omero.data.dir directory, but this will be clear from the error message on the command line. Something like:

  C:\ome.git>cd noaccess
  Access is denied.
  
  C:\ome.git>dist\bin\omero admin cleanse --dry-run c:\ome.git\noaccess
  Using session 1bf8aac2-4a8a-4702-b370-589ac3c0c4ad (root@gretzky.openmicroscopy.org.uk:4064). Idle timeout: 10.0 min. Current group: system
  Reconciling OMERO data directory...
   c:\ome.git\noaccess\Files
  Cleansing context: 0 files (0 bytes)
  Traceback (most recent call last):
    File "C:\ome.git\dist\bin\\omero", line 123, in <module>
      rv = omero.cli.argv()
    File "C:\ome.git\dist\lib\python\omero\cli.py", line 1183, in argv
      cli.invoke(args[1:])
    File "C:\ome.git\dist\lib\python\omero\cli.py", line 733, in invoke
      stop = self.onecmd(line, previous_args)
    File "C:\ome.git\dist\lib\python\omero\cli.py", line 802, in onecmd
      self.execute(line, previous_args)
    File "C:\ome.git\dist\lib\python\omero\cli.py", line 882, in execute
      args.func(args)
    File "C:\ome.git\dist\lib\python\omero\plugins\admin.py", line 955, in cleanse
      config_service=client.sf.getConfigService())
    File "C:\ome.git\dist\lib\python\omero\util\cleanse.py", line 210, in cleanse
      cleanser.cleanse(full_path)
    File "C:\ome.git\dist\lib\python\omero\util\cleanse.py", line 100, in cleanse
      for file in os.listdir(root):
  WindowsError: [Error 3] The system cannot find the path specified: 'c:\\ome.git\\noaccess\\Files/*.*'