BUG:QA 3079 - findByImage throws NPE

[omero-qa]

​http://qa.openmicroscopy.org.uk/qa/feedback/3079/

Comment: I tried to access the ROI attached to this image. When I close the error message the ROI tool comes up as blank when there should be 20-odd ROIs. Does this mean they have all been deleted?

java.lang.Exception: org.openmicroscopy.shoola.env.data.DSAccessException: Cannot access data. 
Cannot load the ROI for image: 3830833

	at org.openmicroscopy.shoola.env.data.OMEROGateway.handleException(OMEROGateway.java:802)

	at org.openmicroscopy.shoola.env.data.OMEROGateway.loadROI(OMEROGateway.java:6279)

	at org.openmicroscopy.shoola.env.data.OmeroImageServiceImpl.loadROIFromServer(OmeroImageServiceImpl.java:858)

	at org.openmicroscopy.shoola.env.data.views.calls.ServerSideROILoader$1.doCall(ServerSideROILoader.java:75)

	at org.openmicroscopy.shoola.env.data.views.BatchCall.doStep(BatchCall.java:144)

	at org.openmicroscopy.shoola.util.concur.tasks.CompositeTask.doStep(CompositeTask.java:226)

	at org.openmicroscopy.shoola.env.data.views.CompositeBatchCall.doStep(CompositeBatchCall.java:126)

	at org.openmicroscopy.shoola.util.concur.tasks.ExecCommand.exec(ExecCommand.java:165)

	at org.openmicroscopy.shoola.util.concur.tasks.ExecCommand.run(ExecCommand.java:274)

	at org.openmicroscopy.shoola.util.concur.tasks.AsyncProcessor$Runner.run(AsyncProcessor.java:91)

	at java.lang.Thread.run(Unknown Source)

Caused by: omero.InternalException

    serverStackTrace = "java.lang.NullPointerException

                        "

    serverExceptionClass = "java.lang.NullPointerException"

    message = ""

	at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)

	at sun.reflect.NativeConstructorAccessorImpl.newInstance(Unknown Source)

	at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(Unknown Source)

	at java.lang.reflect.Constructor.newInstance(Unknown Source)

	at java.lang.Class.newInstance0(Unknown Source)

	at java.lang.Class.newInstance(Unknown Source)

	at IceInternal.BasicStream$DynamicUserExceptionFactory.createAndThrow(BasicStream.java:2243)

	at IceInternal.BasicStream.throwException(BasicStream.java:1632)

	at IceInternal.Outgoing.throwUserException(Outgoing.java:442)

	at omero.api._IRoiDelM.findByImage(_IRoiDelM.java:99)

	at omero.api.IRoiPrxHelper.findByImage(IRoiPrxHelper.java:116)

	at omero.api.IRoiPrxHelper.findByImage(IRoiPrxHelper.java:88)

	at org.openmicroscopy.shoola.env.data.OMEROGateway.loadROI(OMEROGateway.java:6258)

	... 9 more



	at org.openmicroscopy.shoola.env.ui.UserNotifierImpl.showErrorDialog(UserNotifierImpl.java:159)

	at org.openmicroscopy.shoola.env.ui.UserNotifierImpl.notifyError(UserNotifierImpl.java:246)

	at org.openmicroscopy.shoola.env.ui.UserNotifierImpl.notifyError(UserNotifierImpl.java:218)

	at org.openmicroscopy.shoola.agents.measurement.MeasurementViewerLoader.handleException(MeasurementViewerLoader.java:123)

	at org.openmicroscopy.shoola.env.data.events.DSCallAdapter.eventFired(DSCallAdapter.java:84)

	at org.openmicroscopy.shoola.env.data.views.BatchCallMonitor$1.run(BatchCallMonitor.java:124)

	at java.awt.event.InvocationEvent.dispatch(Unknown Source)

	at java.awt.EventQueue.dispatchEvent(Unknown Source)

	at java.awt.EventDispatchThread.pumpOneEventForFilters(Unknown Source)

	at java.awt.EventDispatchThread.pumpEventsForFilter(Unknown Source)

	at java.awt.EventDispatchThread.pumpEventsForHierarchy(Unknown Source)

	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)

	at java.awt.EventDispatchThread.pumpEvents(Unknown Source)

	at java.awt.EventDispatchThread.run(Unknown Source)

[cxallan]

Server relevant log:

2010-12-16 17:13:01,726 INFO  [        ome.services.util.ServiceHandler] (.Server-43)  Executor.doWork -- ome.services.blitz.impl.RoiI.findByImage(3830833, null)
2010-12-16 17:13:01,726 INFO  [        ome.services.util.ServiceHandler] (.Server-43)  Args:	[null, ome.tools.spring.InternalServiceFactory@488d8e1e]
2010-12-16 17:13:01,727 INFO  [         ome.security.basic.EventHandler] (.Server-43)  Auth:	user=3159,group=2,event=null(User),sess=80e9f139-c83e-4296-a7ef-e5d93a01c579
2010-12-16 17:13:01,746 INFO  [                 org.perf4j.TimingLogger] (.Server-43) start[1292519581726] time[20] tag[omero.call.success.ome.services.blitz.impl.RoiI$3.doWork]
2010-12-16 17:13:01,746 INFO  [        ome.services.util.ServiceHandler] (.Server-43)  Rslt:	(ome.model.roi.Roi:Id_1008, ome.model.roi.Roi:Id_1009, ome.model.roi.Roi:Id_1010, ... 23 more)

Client output:

In [44]: roi.findByImage(3830833L, None)
---------------------------------------------------------------------------
InternalException                         Traceback (most recent call last)

/homes/callan/<ipython console> 

/home/jboss/OMERO-CURRENT/lib/python/omero_api_IRoi_ice.pyc in findByImage(self, imageId, opts, _ctx)
    376 
    377         def findByImage(self, imageId, opts, _ctx=None):
--> 378             return _M_omero.api.IRoi._op_findByImage.invoke(self, ((imageId, opts), _ctx))
    379 
    380         def findByImage_async(self, _cb, imageId, opts, _ctx=None):

InternalException: exception ::omero::InternalException
{
    serverStackTrace = java.lang.NullPointerException

    serverExceptionClass = java.lang.NullPointerException
    message = 
}

[jburel]

Moved from sprint 2010-12-23 (22)

[jmoore]

(In [8764/omero]) Fix NPE on null shape in RoiResultReturnMapper (Fix #3703)

[jmoore]

(In [8821/omero]) Fix NPE on null shape in RoiResultReturnMapper (See #3703)

original-svn-id: ​file:///home/svn/omero/trunk@8764 05709c45-44f0-0310-885b-81a1db45b4a6