User Story #3776 (closed)
Opened 13 years ago
Closed 13 years ago
BUG: Collaborative group broken thumbnails and viewer
Reported by: | cxallan | Owned by: | wmoore |
---|---|---|---|
Priority: | blocker | Milestone: | OMERO-Beta4.3.1 |
Component: | General | Keywords: | n.a. |
Cc: | atarkowska, cneves, wmoore | Story Points: | n.a. |
Sprint: | n.a. | Importance: | n.a. |
Total Remaining Time: | 0.0d | Estimated Remaining Time: | n.a. |
Description (last modified by cxallan)
Since the merges started before Christmas in r8617, thumbnails cannot be rendered for other users and the viewer is not usable. This is due to the _getRDef and _createRDef logic that was merged in that does not handle multiple users and permissions correctly.
The code path is:
-- getThumbnail \-- _prepareTB \-- _getRDef \-- _createRDef
Fundamentally this entire code path needs to be reviewed and separated from the single rendering definition logic and the exclusive use of Direct thumbnail retrieval methods.
Change History (10)
comment:1 Changed 13 years ago by cxallan
- Cc atarkowska cneves-x added
comment:2 Changed 13 years ago by jburel
- Sprint changed from 2011-01-13 (23) to 2011-01-27 (24)
comment:3 Changed 13 years ago by wmoore
- Cc wmoore added
comment:4 Changed 13 years ago by cxallan
- Sprint 2011-01-27 (4) deleted
Referencing ticket #3769 has changed sprint.
comment:5 Changed 13 years ago by cxallan
Verified to still be broken as of [b4d2f2db2ec1b4711686664311a1044f55d3ef52/ome.git].
comment:6 Changed 13 years ago by cxallan
- Description modified (diff)
- Priority changed from minor to blocker
- Summary changed from BUG: Collaborative group broken thumbnails to BUG: Collaborative group broken thumbnails and viewer
- Type changed from Task to User Story
comment:7 Changed 13 years ago by wmoore
From #3798
Viewing another user's image in a read-only group.
Traceback: File "/Users/will/Documents/workspace/Omero/dist/lib/python/django/core/handlers/base.py" in get_response 92. response = callback(request, *callback_args, **callback_kwargs) File "/Users/will/Documents/workspace/Omero/dist/lib/python/omeroweb/webgateway/views.py" in render_image 595. jpeg_data = img.renderJpeg(z,t, compression=compress_quality) File "/Users/will/Documents/workspace/Omero/dist/lib/python/omero/gateway/__init__.py" in wrapped 4727. if not self._prepareRenderingEngine(): File "/Users/will/Documents/workspace/Omero/dist/lib/python/omero/gateway/__init__.py" in _prepareRenderingEngine 4944. self._re = self._prepareRE() File "/Users/will/Documents/workspace/Omero/dist/lib/python/omero/gateway/__init__.py" in _prepareRE 4911. pid, rdid = self._getRDef(forcenew=forcenew) File "/Users/will/Documents/workspace/Omero/dist/lib/python/omero/gateway/__init__.py" in _getRDef 4889. pid, rdid = self._createRDef() File "/Users/will/Documents/workspace/Omero/dist/lib/python/omero/gateway/__init__.py" in _createRDef 4866. return pixels_id, rdid.id.val Exception Type: AttributeError at /webgateway/render_image/3594/0/0/ Exception Value: 'NoneType' object has no attribute 'id'
comment:8 Changed 13 years ago by agilo
- Status changed from new to accepted
Updated status, related task in progress
comment:9 Changed 13 years ago by jmoore
- Milestone changed from OMERO-Beta4.3 to OMERO-Beta4.3.1
- Owner set to wmoore
Passing to will for testing.
comment:10 Changed 13 years ago by wmoore
- Resolution set to fixed
- Status changed from accepted to closed
Viewing another user's thumbnails (even if they had imported without viewing) seemed OK in collab and read-only group.
No errors in OMERO.web log except due to trying to view thumbnails while image was still importing.
Seems bugs are fixed.
Referencing ticket #3769 has changed sprint.