Task #3843 (closed)
chgrp: refactor IAdmin.changeGroup to use chgrp.
| Reported by: | jamoore | Owned by: | jamoore |
|---|---|---|---|
| Priority: | major | Milestone: | OMERO-4.4 |
| Component: | Services | Version: | n.a. |
| Keywords: | n.a. | Cc: | jburel |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | n.a. |
Description
Like IDelete.deleteObject(), the iAdmin.changeGroup method will eventually be too simplistic for seriously working with the OME graphs. However, initial testing can still be done with it.
Change History (14)
comment:1 Changed 13 years ago by jmoore
- Status changed from new to accepted
comment:2 Changed 13 years ago by jburel
- Sprint changed from 2011-01-13 (23) to 2011-01-27 (24)
comment:3 Changed 13 years ago by jmoore
- Owner jmoore deleted
- Status changed from accepted to new
comment:4 Changed 13 years ago by jmoore
- Sprint 2011-01-27 (4) deleted
Referencing ticket #2030 has changed sprint.
comment:5 Changed 13 years ago by jmoore
Referencing ticket #2030 has changed sprint.
comment:6 Changed 13 years ago by jmoore
- Milestone changed from OMERO-Beta4.3 to Unscheduled
Moving back to Unscheduled as we approach the freeze for 4.3
comment:7 Changed 13 years ago by jmoore
- Cc jburel added
- Milestone changed from Unscheduled to OMERO-Beta4.3.2
- Owner set to jmoore
- Sprint set to 2011-09-01 (4)
Because of the time that a chgrp operation can take, it seems dangerous to allow the IAdmin.changeGroup method. Does it suffice to deprecate it for 4.3.2? Should we make it throw an exception? It currently is almost guaranteed to do so.
comment:8 Changed 13 years ago by jburel
- Sprint changed from 2011-09-01 (4) to 2011-09-15 (5)
Moved from sprint 2011-09-01 (4)
comment:9 Changed 13 years ago by jburel
The methods should actually be removed from services.
comment:10 Changed 13 years ago by jburel
- Sprint changed from 2011-09-15 (5) to 2011-09-29 (6)
Moved from sprint 2011-09-15 (5)
comment:11 Changed 13 years ago by jburel
- Milestone changed from OMERO-Beta4.3.2 to OME-5.0
- Sprint 2011-09-29 (6) deleted
comment:12 Changed 12 years ago by jmoore
- Summary changed from chgrp: initial test with IAdmin.changeGroup to chgrp: refactor IAdmin.changeGroup to use chgrp.
Now that the chgrp API is complete, there's no reason to do any testing at this level. Instead, the method needs to be refactored, even though it's already be deprecated.
comment:13 Changed 12 years ago by jburel
- Remaining Time changed from 0.25 to 0
- Resolution set to invalid
- Status changed from new to closed
comment:14 Changed 12 years ago by jmoore
Instead deprecated method:
commit b5ad91409fdb9236671f19b25d11e0a37224692f
Author: jmoore <josh@glencoesoftware.com>
Date: Tue Mar 27 13:32:43 2012
Deprecate some old style, synchronous IAdmin methods
diff --git a/components/blitz/resources/omero/api/IAdmin.ice b/components/blitz/resources/omero/api/IAdmin.ice
index 7a4b580..533e90d 100644
--- a/components/blitz/resources/omero/api/IAdmin.ice
+++ b/components/blitz/resources/omero/api/IAdmin.ice
@@ -65,8 +65,14 @@ module omero {
idempotent void removeGroupOwners(omero::model::ExperimenterGroup group, ExperimenterList owners) throws ServerError;
idempotent void deleteExperimenter(omero::model::Experimenter user) throws ServerError;
idempotent void deleteGroup(omero::model::ExperimenterGroup group) throws ServerError;
+
+ ["deprecated:changeOwner() is deprecated. use omero::cmd::Chown() instead."]
idempotent void changeOwner(omero::model::IObject obj, string omeName) throws ServerError;
+
+ ["deprecated:changeGroup() is deprecated. use omero::cmd::Chgrp() instead."]
idempotent void changeGroup(omero::model::IObject obj, string omeName) throws ServerError;
+
+ ["deprecated:changePermissions() is deprecated. use omero::cmd::Chmod() instead."]
idempotent void changePermissions(omero::model::IObject obj, omero::model::Permissions perms) throws ServerError;
idempotent void moveToCommonSpace(IObjectList objects) throws ServerError;
Referencing ticket #2030 has changed sprint.