Warning: Can't synchronize with repository "(default)" (/home/git/ome.git does not appear to be a Git repository.). Look in the Trac log for more information.
Notice: In order to edit this ticket you need to be either: a Product Owner, The owner or the reporter of the ticket, or, in case of a Task not yet assigned, a team_member"

Task #4011 (closed)

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

Bug: with new session cache, getEventContext() may be stale!

Reported by: jamoore Owned by: jamoore
Priority: critical Milestone: OMERO-Beta4.3
Component: Security Version: n.a.
Keywords: n.a. Cc: jburel, atarkowska, cxallan, cneves
Resources: n.a. Referenced By: n.a.
References: n.a. Remaining Time: 0.0d
Sprint: 2011-02-10 (5)

Description

Needs verifying with a test, but after:

 admin.addGroup(exp, [grp])

the return value of

 admin.getEventContext()

will probably not contain the new group.

Change History (11)

comment:1 Changed 12 years ago by jmoore

  • Owner set to jmoore
  • Remaining Time set to 0.5
  • Sprint set to 2011-02-10 (5)

Moving to (5) for "bug" cleanup

comment:2 Changed 12 years ago by jmoore

  • Status changed from new to accepted

comment:3 Changed 12 years ago by Josh <josh@…>

(In [2e115b2962e4b4abc82e175b88dd371141bc4b55/ome.git]) Return reloading EventContext on IAdmin.getEventContext (See #4011)

This introduces new methods to the SecuritySystem and SessionManager
interfaces which allow getting a reloaded version of the current users
event context. This is used by IAdmin.getEventContext always, and
can be used in other locations later at the cost of a longer invocation
as data is read from the DB.

comment:4 Changed 12 years ago by Josh <josh@…>

  • Remaining Time changed from 0.5 to 0
  • Resolution set to fixed
  • Status changed from accepted to closed

(In [592c76e66eb7943f4201865ce1fa42fd0e4c3d0c/ome.git]) Storing freshly loaded SessionContext back to cache (Fix #4011)

This is just a performance optimization so fewer code paths have
to force a reload themself.

comment:5 Changed 12 years ago by Josh <josh@…>

(In [542e54f87ad0870af81741d9806d3fc7c8856d38/ome.git]) Adding new method to other SecuritySystem implementors (See #4011)

comment:6 Changed 12 years ago by jmoore <josh@…>

(In [fb41050de4c6aa8af9a8c2c9027d4674226005c3/ome.git] on branch develop) Forcing reload of user context in test (Fix #4384, See #4011)

comment:7 Changed 12 years ago by jmoore <josh@…>

(In [1025f83842e6070fcf533b1707e27fe4f3359364/ome.git] on branch dev_4_2) Return reloading EventContext on IAdmin.getEventContext (See #4011)

This introduces new methods to the SecuritySystem and SessionManager
interfaces which allow getting a reloaded version of the current users
event context. This is used by IAdmin.getEventContext always, and
can be used in other locations later at the cost of a longer invocation
as data is read from the DB.

comment:8 Changed 12 years ago by jmoore <josh@…>

(In [b7ac15a2613f096c5fb919af075253d3a5c1d5a4/ome.git] on branch dev_4_2) Storing freshly loaded SessionContext back to cache (Fix #4011)

This is just a performance optimization so fewer code paths have
to force a reload themself.

comment:9 Changed 12 years ago by jmoore <josh@…>

(In [64ff552ad1f73fcc849dba60dd06ebb4fb841475/ome.git] on branch dev_4_2) Adding new method to other SecuritySystem implementors (See #4011)

comment:10 Changed 12 years ago by jmoore <josh@…>

(In [8ad0c4de414ee5589601bf11746700cc9396e2f9/ome.git] on branch dev_4_2) Forcing reload of user context in test (Fix #4384, See #4011)

comment:11 Changed 12 years ago by jmoore <josh@…>

(In [bd138a37947b11b8b60b31431433a1a44c70d6ff/ome.git] on branch develop) Reduce calls to IAdmin.getEventContext (See #4011, #5711)

Note: See TracTickets for help on using tickets. You may also have a look at Agilo extensions to the ticket.

1.3.13-PRO © 2008-2011 Agilo Software all rights reserved (this page was served in: 0.64703 sec.)

We're Hiring!