Task #4183 (new)
Opened 13 years ago
Make sure that static fields are being used properly — at Initial Version
Reported by: | mlinkert | Owned by: | mlinkert-x |
---|---|---|---|
Priority: | major | Milestone: | OMERO-Beta4.3 |
Component: | Bio-Formats | Version: | n.a. |
Keywords: | sprint-1 | Cc: | jamoore |
Resources: | n.a. | Referenced By: | n.a. |
References: | n.a. | Remaining Time: | n.a. |
Sprint: | n.a. |
Description
There are several static (non-final) HashMaps/Hashtables? throughout the reader classes that could be made final.
The 'uuids' field in OMETiffWriter is static, but it is never cleared. If possible, it would be best to make this field non-static, or at least provide a mechanism for clearing stale entries to prevent memory leaks.
Similarly, the Location has several static fields (including 'idMap' and 'fileListings') for which it would be nice to have a master reset method that clears the HashMaps/Hashtables? and resets associated fields to their original state.
Finally, we need to ensure that static fields are accessed in a thread-safe manner.