Task #4349 (closed)
Opened 8 years ago
Closed 8 years ago
BUG: ROI-shape Font Style to DB
| Reported by: | wmoore | Owned by: | jburel |
|---|---|---|---|
| Priority: | minor | Milestone: | OMERO-Beta4.3 |
| Component: | Insight | Version: | n.a. |
| Keywords: | n.a. | Cc: | dzmacdonald |
| Resources: | n.a. | Referenced By: | n.a. |
| References: | n.a. | Remaining Time: | 0.0d |
| Sprint: | 2011-02-24 (6) |
Description (last modified by jburel)
The 'FontStyle?' attribute of Shape is always saved as 'italic' even if the style has previously been saved as something else (E.g. another client saves 'Bold'). It's OK not to support FontStyle? in Insight, but data from other clients should not be overwritten by default.
See #4317 for ROI data-model ticket.
Change History (9)
comment:1 Changed 8 years ago by wmoore
- Cc dzmacdonald added
- Description modified (diff)
- Summary changed from BUG: ROI visibility not saved to DB to BUG: ROI-shape saving to DB
comment:2 Changed 8 years ago by jburel
- Remaining Time set to 0.5
comment:3 Changed 8 years ago by jburel
comment:4 Changed 8 years ago by wmoore
Sure - the model only supports
- FontStyle' (Bold, BoldItalic, Italic, Regular),
- FontSize (int)
- FontFamily (Courier, Helvetical, Arial, TimesNewRoman)
so it would be good to get rid of font weight (and remove from DB). In fact there are a bunch of other columns that could be removed from the DB too.
comment:5 Changed 8 years ago by jburel
For font family, we should have a larger enumeration or nothing at all.
I will check which piece of code enters value in font weight.
comment:6 Changed 8 years ago by jburel
- Status changed from new to accepted
comment:7 Changed 8 years ago by jburel
- Description modified (diff)
comment:8 Changed 8 years ago by jburel
- Description modified (diff)
- Summary changed from BUG: ROI-shape saving to DB to BUG: ROI-shape Font Style to DB
comment:9 Changed 8 years ago by jburel <j.burel@…>
- Remaining Time changed from 0.5 to 0
- Resolution set to fixed
- Status changed from accepted to closed
(In [5f270a30e3fd6961c95b67b6c8d9eb7a97510c6e/ome.git] on branch develop) Fixed problem related to font style. Font weight is no longer used (close #4349)
Is that OK if we pick font style and as part of the update script remove font weight and merge the value. Note that I always have font weight bold if font style is italic.