Bug: insight import fails with NPE in ome.util.PixelData

[jamoore]

     [echo] Launching OMERO.insight ...
     [java] java.lang.NullPointerException
     [java] 	at ome.util.PixelData.bytesPerPixel(PixelData.java:162)
     [java] 	at ome.util.PixelData.<init>(PixelData.java:78)
     [java] 	at ome.formats.importer.OMEROWrapper.openPlane2D(OMEROWrapper.java:186)
     [java] 	at ome.formats.importer.ImportLibrary.writeDataBlockBased(ImportLibrary.java:806)
     [java] 	at ome.formats.importer.ImportLibrary.importData(ImportLibrary.java:736)
     [java] 	at ome.formats.importer.ImportLibrary.importImage(ImportLibrary.java:558)
     [java] 	at org.openmicroscopy.shoola.env.data.OMEROGateway.importImage(OMEROGateway.java:6043)
     [java] 	at org.openmicroscopy.shoola.env.data.OmeroImageServiceImpl.importFile(OmeroImageServiceImpl.java:1031)

See #4835, only on branch team/feature/4835-repo-refactoring

[jburel]

Seems to be a problem in importer. I will add a control so that the application does not crash

[jmoore]

I've fixed the NPE on the branch (pushing now).

[jburel]

we can probably close the ticket?

[jmoore]

Fixed in [2f8bfe834430b395c81725de9b6071b660704b42/ome.git]:

Author: jmoore <josh@glencoesoftware.com>
Date:   Mon Apr 4 22:41:22 2011 +0200

    `PixelData` fix by setting field before method call in ctor

diff --git a/components/model/src/ome/util/PixelData.java b/components/model/src/ome/util/PixelData.java
index 953642d..2390962 100644
--- a/components/model/src/ome/util/PixelData.java
+++ b/components/model/src/ome/util/PixelData.java
@@ -75,6 +75,7 @@ public class PixelData
    public PixelData(String pixelsType, ByteBuffer data)
    {
        this.data = data;
+       this.pixelsType = pixelsType;
        bytesPerPixel = bytesPerPixel();
        if (pixelsType.equals("int8")) {
            isSigned = true;