Bug: gateway's getPlanes does not handle exceptions.

[jamoore]

In [ab7842f2b19e7120375b278589493dbd6b20aea7/ome.git] a try/finally was removed from a generator and replaced by except:pass which would swallow any exceptions.

        try:
           for zct in zctList:
               z,c,t = zct
               rawPlane = rawPixelsStore.getPlane(z, c, t)
               convertedPlane = unpack(convertType, rawPlane)
               remappedPlane = numpy.array(convertedPlane, numpyType)
               remappedPlane.resize(sizeY, sizeX)
               yield remappedPlane
       except:
           pass
       rawPixelsStore.close()

The proper idiom (though ugly) is probably:

svc = createService()
exc = None
try:
    yield svc.method()
except exceptions.Exception, e:
    exc = e
try:
    svc.close()
except exceptions.Exception, e:
    if exc is None:
         exc = e
    else:
        log.error(e)

if exc is not None:
   raise exc

We may want to create a method or decorator to handle this logic if it will be used frequently.

[jmoore <josh@…>]

(In [500817cb70e05b2f69017cc9131e484c0cfbd9af/ome.git] on branch develop) Adding tests showing expected behavior of try/except (See #5156)

[Aleksandra Tarkowska <aleksandrat@…>]

(In [ff2f002cec81ad8cfebc396b0b41bb9fbfec96f0/ome.git] on branch develop) this fixes #5156

[jmoore]

Running tests the there is still an error:

~/git/components/tools/OmeroPy $ python test/gatewaytest/pixels.py PixelsTest.testGetPlanesExceptionOnClose
Traceback (most recent call last):
  File "test/gatewaytest/pixels.py", line 169, in testGetPlanesExceptionOnClose
    for x in pixels.getPlanes(((0,0,0), (1,1,1))):
  File "/Users/moore/git/components/tools/OmeroPy/build/lib/omero/gateway/__init__.py", line 4422, in getTiles
    except exceptions.Exception, e:
NameError: global name 'exceptions' is not defined
E
======================================================================
ERROR: testGetPlanesExceptionOnClose (__main__.PixelsTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/gatewaytest/pixels.py", line 177, in testGetPlanesExceptionOnClose
    self.assert_(e.close)
AttributeError: 'exceptions.NameError' object has no attribute 'close'

----------------------------------------------------------------------
Ran 1 test in 3.931s

FAILED (errors=1)

to get the extra print out of the internal stack trace I added this temporarily:

~/git/components/tools/OmeroPy $ git diff .
diff --git a/components/tools/OmeroPy/test/gatewaytest/pixels.py b/components/tools/OmeroPy/test/gatewaytest/pixels.py
index ae102ee..27f08e7 100644
--- a/components/tools/OmeroPy/test/gatewaytest/pixels.py
+++ b/components/tools/OmeroPy/test/gatewaytest/pixels.py
@@ -172,6 +172,8 @@ class PixelsTest (lib.GTest):
         except AssertionError:
             raise
         except exceptions.Exception, e:
+            import traceback as tb
+            tb.print_exc()
             self.assert_(e.close)
             self.assertEquals(2, found)
 

[Aleksandra Tarkowska <aleksandrat@…>]

(In [8bb57f3e15ba21ef45d8ec35af7ebe80879c3b5f/ome.git] on branch develop) this fixes NameError?: global name 'exceptions' is not defined, see #5156

[Will Moore <will@…>]

(In [bb26971090ff3236cdff05af9b0f24fe3f1b3bf1/ome.git] on branch develop) Better error reporting for pixelWrapper.getTiles(). See #5151, #5156