Review pylint errors for omeroweb

[jamoore]

These were found while working on #4749, and is the web-counterpart to #5182:

~/git/dist/lib/python $ pylint-2.6 -E -d E1103,E1101,E1002,E0611 -i yes omeroweb
No config file found, using default configuration
... snip ...
************* Module omeroweb.webadmin.custom_forms
E1102:162:GroupModelMultipleChoiceField: _ is not callable
E1102:163:GroupModelMultipleChoiceField: _ is not callable
E1102:242:ExperimenterQuerySetIterator.__iter__: _ is not callable
E1102:294:ExperimenterModelMultipleChoiceField: _ is not callable
E1102:295:ExperimenterModelMultipleChoiceField: _ is not callable
************* Module omeroweb.webadmin.views
E0602:954:load_drivespace: Undefined variable 'handlerInternalError'
************* Module omeroweb.webadmin.controller.drivespace
E0602: 50:_bytes_per_pixel: Undefined variable 'logger'
E0602: 51:_bytes_per_pixel: Undefined variable 'logger'
E0602: 51:_bytes_per_pixel: Undefined variable 'traceback'
************* Module omeroweb.webadmin.tests.unittests
E0602:723:_changePassword: Undefined variable 'form'
E0602:724:_changePassword: Undefined variable 'self'
E0602:726:_changePassword: Undefined variable 'form'
E0602:727:_changePassword: Undefined variable 'self'
E0602:743:_createGroup: Undefined variable 'self'
E0602:759:_updateGroup: Undefined variable 'self'
E0602:794:_createExperimenter: Undefined variable 'self'
E0602:830:_updateExperimenter: Undefined variable 'self'
************* Module omeroweb.webclient.custom_forms
E1102:180:AnnotationModelMultipleChoiceField: _ is not callable
E1102:181:AnnotationModelMultipleChoiceField: _ is not callable
E1102:278:ObjectModelMultipleChoiceField: _ is not callable
E1102:279:ObjectModelMultipleChoiceField: _ is not callable
************* Module omeroweb.webclient.views
E0602:1562:manage_action_containers: Undefined variable 'source'
E0602:1816:basket_action: Undefined variable 'o_type'
E0602:1816:basket_action: Undefined variable 'oid'
E0602:1857:basket_action: Undefined variable 'o_type'
E0602:1857:basket_action: Undefined variable 'oid'
************* Module omeroweb.webclient.webclient_gateway
E0601: 36: Using variable 'logger' before assignment
E0203:1750:OmeroWebObjectWrapper.countAnnotations: Access to member 'annotation_counter' before its definition line 1756
E0203:1751:OmeroWebObjectWrapper.countAnnotations: Access to member 'annotation_counter' before its definition line 1756
E0102:1941:ShareWrapper: class already defined line 1872
************* Module omeroweb.webclient.controller.container
E0602:313:BaseContainer.loadHierarchies: Undefined variable 'ProjectI'
E0602:315:BaseContainer.loadHierarchies: Undefined variable 'DatasetI'
************* Module omeroweb.webclient.tests.seleniumtests
E0602: 44:WebClientTestBase.import_image: Undefined variable 'path'
E0602: 46:WebClientTestBase.import_image: Undefined variable 'subprocess'
E0602: 46:WebClientTestBase.import_image: Undefined variable 'subprocess'
E0602: 46:WebClientTestBase.import_image: Undefined variable 'subprocess'
E0602: 50:WebClientTestBase.import_image: Undefined variable 'exceptions'
************* Module omeroweb.webemdb.views
E0602: 65:eman: Undefined variable 'EMNumPy'
E0602:309:dataset_stack: Undefined variable 'EMNumPy'
E0602:315:dataset_stack: Undefined variable 'EMData'
E0602:457:projection_axis: Undefined variable 'EMNumPy'
************* Module omeroweb.webmobile.views
E0602:108:change_active_group: Undefined variable 'handlerInternalError'
************* Module omeroweb.webtest.views
E0601: 24: Using variable 'logger' before assignment

[jburel]

Moved from sprint 2011-05-19 (12)

[jburel]

Moved from sprint 2011-06-02 (13)

[jburel]

Moved from sprint 2011-06-16 (14)

[atarkowska]

This issue should be addressed in the global level, by Hudson or as a test scenario.

[jmoore]

Yup. There's another ticket (#2591) for turning on pylint checking on hudson, but turning it on now would just break the build until we get it a bit cleaned up.

[Aleksandra Tarkowska <A.Tarkowska@…>]

(In [1d252027c58ff28d8ae5bfabad97fad50c5212b3/ome.git] on branch develop) this fix pylint errors, close #5183